node: Fix false negative connection to FS chain in multi-endpoint setup #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2987 +/- ##
=======================================
Coverage 22.88% 22.89%
=======================================
Files 785 785
Lines 58778 58779 +1
=======================================
+ Hits 13454 13457 +3
+ Misses 44443 44442 -1
+ Partials 881 880 -1 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Oct 29, 2024
Defect of 0d08b51. Previously, node unconditionally visited all configured FS chain endpoints, and the result of the connection to the last address was final. In the case where the previous nodes (at least one) were available but the last one was not, a general init error occurred. Now node breaks on first successful dial. Fixes #2986. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
bugfix/2986-fschain-recon
branch
from
03efcc0
to
8597a10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect of 0d08b51. Previously, node unconditionally visited all configured FS chain endpoints, and the result of the connection to the last address was final. In the case where the previous nodes (at least one) were available but the last one was not, a general init error occurred.
Now node breaks on first successful dial.
Fixes #2986.