Fix/relay requests #3014
Merged
Fix/relay requests #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
requested review from
roman-khimov and
cthulhu-rider
as code owners
carpawell
force-pushed
the
fix/relay-requests
branch
from
ad67940
to
fb7b9ba
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3014 +/- ##
==========================================
- Coverage 22.84% 22.83% -0.01%
==========================================
Files 790 790
Lines 58344 58362 +18
==========================================
+ Hits 13328 13329 +1
- Misses 44136 44153 +17
Partials 880 880 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Nov 13, 2024
| @@ -325,6 +325,7 @@ func (x placementIterator) iterateNodesForObject(obj oid.ID, f func(nodeDesc) er | |||
| return | |||
| } | |||
| }); err != nil { | |||
| wg.Done() | |||
There was a problem hiding this comment.
A bit different (and incomplete) story.
There was a problem hiding this comment.
agree, just did not want two PRs after the same debug session in fact
carpawell
force-pushed
the
fix/relay-requests
branch
from
fb7b9ba
to
05507da
Compare
cthulhu-rider
approved these changes
Nov 14, 2024
CHANGELOG.md
Outdated
| @@ -29,6 +29,7 @@ attribute, which is used for container domain name in NNS contracts (#2954) | |||
| - RPC client reconnection failures leading to complete SN failure (#2797) | |||
| - `meta.DB.Open(readOnly)` moves metabase in RO mode (#3000) | |||
| - Panic in event listener related to inability to switch RPC node (#2970) | |||
| - Non-container nodes never checks placement policy on PUT requests (#3014) | |||
There was a problem hiding this comment.
hm, how many devs are required to write this word right
It was not possible to read an error from a node that answers with status codes, not with a gRPC error, so relay nodes always PUT objects without errors. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
force-pushed
the
fix/relay-requests
branch
from
05507da
to
0f05dec
Compare
It does not change the seen behavior, but now error logs will be printed. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
If `wg.Add` was called, `wg.Done` must be executed in any way. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
force-pushed
the
fix/relay-requests
branch
from
0f05dec
to
3ea9280
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.