Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to mark all items read #312

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Shiandow
Copy link

Since it was inconvenient to have to open each page in order to mark them read I've added a context menu item to mark items as read.

Unfortunately I wasn't able to add all of the corresponding locales entries for it as I do not speak most of those languages. It works fine in English.

@Shiandow
Copy link
Author

Shiandow commented Dec 22, 2020

This solves #213.

Copy link
Owner

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Just one small comment.

Happy holidays btw! Sorry it took me a while to get to this.

background/background.js Outdated Show resolved Hide resolved
Suggested nt1m

Co-authored-by: Tim Nguyen <nt1m@users.noreply.github.com>
@Shiandow
Copy link
Author

Hey, no problems, given the holidays I wasn't expecting a quick reply.

I've added your suggested change.

Happy holidays to you too!

@nt1m
Copy link
Owner

nt1m commented Feb 27, 2021

@evilpie wdyt of this PR? It does what it should, but not sure it's going to be expected for users to have their history filled when they click this item

@evilpie
Copy link
Collaborator

evilpie commented Feb 27, 2021

I have the same concern. Maybe we could make this side-effect more obvious with some different language like "Mark all as read/visited", but I honestly don't like that phrasing myself.

Maybe it's fine to add, worst case you can always delete something from your history?

@sukiletxe
Copy link

As a user who has lots of unread items due to losing his history, I agree with this design. Given that currently there is no other way to mark items as read (and I'm not saying there should be), I think it's a good solution.

@Philipp0205
Copy link

Can this be merged pls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants