Fix branch name error with special char #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Piazzi <lpiazzi26@gmail.com>
franpilot
requested changes
Sep 14, 2023
franpilot
reviewed
Sep 15, 2023
Fix code to address clojure style guide Co-authored-by: Francine Pilot <francine.pilot@nubank.com.br>
Signed-off-by: Lucas Piazzi <lpiazzi26@gmail.com>
Signed-off-by: Lucas Piazzi <lpiazzi26@gmail.com>
Signed-off-by: Lucas Piazzi <lpiazzi26@gmail.com>
|
It's missing the new version here |
franpilot
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bookworm service was breaking when there was a
|on the branch name. This fixes the issue by encoding all special characters that exist in the branch nameIssue: https://github.com/nubank/bookworm/issues/506