Skip to content

Commit

Permalink
Update mr.flagly (#2511)
Browse files Browse the repository at this point in the history
  • Loading branch information
javitonino authored Oct 3, 2024
1 parent 6fcfbac commit d60bb6c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 15 deletions.
19 changes: 7 additions & 12 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions nucliadb_node/src/shards/shard_writer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ use super::indexes::{ShardIndexes, DEFAULT_VECTORS_INDEX_NAME};
use super::metadata::ShardMetadata;
use super::versioning::{self, Versions};
use crate::disk_structure::{self, *};
use crate::settings::{feature_flags, Settings};
use crate::settings::Settings;
use crate::telemetry::run_with_telemetry;

const MAX_LABEL_LENGTH: usize = 32768; // Tantivy max is 2^16 - 4
Expand Down Expand Up @@ -106,7 +106,7 @@ impl ShardWriter {
}

#[measure(actor = "shard", metric = "new")]
pub fn new(new: NewShard, shards_path: &Path, settings: &Settings) -> NodeResult<(Self, Arc<ShardMetadata>)> {
pub fn new(new: NewShard, shards_path: &Path, _settings: &Settings) -> NodeResult<(Self, Arc<ShardMetadata>)> {
let span = tracing::Span::current();

if new.vector_configs.is_empty() {
Expand All @@ -120,7 +120,6 @@ impl ShardWriter {

std::fs::create_dir(&shard_path)?;

let ff_context = HashMap::from([("kbid".to_string(), metadata.kbid())]);
let versions = Versions {
paragraphs: versioning::PARAGRAPHS_VERSION,
vectors: versioning::VECTORS_VERSION,
Expand Down

0 comments on commit d60bb6c

Please sign in to comment.