Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text fastfields #2467

Merged
merged 10 commits into from
Sep 20, 2024
Merged

Text fastfields #2467

merged 10 commits into from
Sep 20, 2024

Conversation

javitonino
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.28%. Comparing base (292bf3e) to head (dd657a2).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2467      +/-   ##
==========================================
+ Coverage   86.23%   86.28%   +0.05%     
==========================================
  Files         375      375              
  Lines       23290    23540     +250     
==========================================
+ Hits        20083    20312     +229     
- Misses       3207     3228      +21     
Flag Coverage Δ
nucliadb 73.92% <ø> (+0.04%) ⬆️
nucliadb-ingest 29.10% <ø> (-0.03%) ⬇️
nucliadb-reader 25.04% <ø> (-0.04%) ⬇️
nucliadb-search 37.22% <ø> (-0.02%) ⬇️
nucliadb-standalone 47.02% <ø> (-0.04%) ⬇️
nucliadb-train 45.67% <ø> (-0.04%) ⬇️
nucliadb-writer 39.91% <ø> (-0.04%) ⬇️
nucliadb_dataset 55.31% <ø> (ø)
nucliadb_models 85.18% <100.00%> (-0.04%) ⬇️
nucliadb_sdk 80.11% <ø> (ø)
nucliadb_sidecar 89.03% <ø> (ø)
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jotare jotare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update the Dockerfile.node to add nucliadb_texts3

@javitonino
Copy link
Contributor Author

You forgot to update the Dockerfile.node to add nucliadb_texts3

Ah thanks! ❤️ I thought I got rid of all of that nonsense with the CI refactor, forgot to check the dockefile. Fixed!

@javitonino javitonino merged commit 23064bd into main Sep 20, 2024
51 checks passed
@javitonino javitonino deleted the text_fastfields branch September 20, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants