-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text fastfields #2467
Text fastfields #2467
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
==========================================
+ Coverage 86.23% 86.28% +0.05%
==========================================
Files 375 375
Lines 23290 23540 +250
==========================================
+ Hits 20083 20312 +229
- Misses 3207 3228 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5dc8cd1
to
2a73a06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to update the Dockerfile.node to add nucliadb_texts3
Ah thanks! ❤️ I thought I got rid of all of that nonsense with the CI refactor, forgot to check the dockefile. Fixed! |
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.