Hidden segments #2480
Merged
Hidden segments #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javitonino
force-pushed
the
hidden_segments
branch
from
337010e to
c6f06b1
Compare
javitonino
force-pushed
the
hidden_segments
branch
from
c6f06b1 to
5b682cb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2480 +/- ##
==========================================
+ Coverage 86.17% 86.27% +0.10%
==========================================
Files 376 376
Lines 23507 23507
==========================================
+ Hits 20256 20280 +24
+ Misses 3251 3227 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jotare
approved these changes
Sep 26, 2024
| @@ -271,6 +271,31 @@ pub fn translate( | |||
| }) | |||
| } | |||
|
|
|||
| /// Extract an expression only involving some labels it it's an AND subset of the total expression | |||
There was a problem hiding this comment.
Suggested change
| /// Extract an expression only involving some labels it it's an AND subset of the total expression | |
| /// Extract an expression only involving some labels and it's an AND subset of the total expression |
(not sure)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.