Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_segment_ids compatible with vectorsets #2490

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

javitonino
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@javitonino javitonino force-pushed the replicate_all_vectorsets branch from 443ee11 to 4567af3 Compare September 24, 2024 18:06
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.17%. Comparing base (deb6751) to head (4567af3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2490      +/-   ##
==========================================
- Coverage   86.22%   86.17%   -0.05%     
==========================================
  Files         375      375              
  Lines       23392    23392              
==========================================
- Hits        20170    20159      -11     
- Misses       3222     3233      +11     
Flag Coverage Δ
nucliadb 73.91% <ø> (-0.08%) ⬇️
nucliadb-ingest 29.09% <ø> (ø)
nucliadb-reader 25.01% <ø> (ø)
nucliadb-search 37.25% <ø> (ø)
nucliadb-standalone 47.00% <ø> (ø)
nucliadb-train 45.63% <ø> (ø)
nucliadb-writer 39.95% <ø> (ø)
nucliadb_dataset 55.31% <ø> (ø)
nucliadb_models 85.08% <ø> (ø)
nucliadb_sdk 80.11% <ø> (ø)
nucliadb_sidecar 89.03% <ø> (ø)
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 84.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javitonino javitonino merged commit a15753c into main Sep 25, 2024
51 checks passed
@javitonino javitonino deleted the replicate_all_vectorsets branch September 25, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants