Reindex all questions when adding a new one #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2526 +/- ##
==========================================
- Coverage 86.28% 86.22% -0.07%
==========================================
Files 376 376
Lines 23580 23566 -14
==========================================
- Hits 20347 20320 -27
- Misses 3233 3246 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
replace_field was always True replace_splits contained deleted_splits, we now always delete them when replacing the field (which is always true)
javitonino
force-pushed
the
conversation_index
branch
from
14808b1 to
c968fd6
Compare
lferran
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Always send all splits to the index each time
This makes it so we send the entire conversation field to the index when adding a new question. This way the granularity of the index is the field and it doesn't have to know about splits and could make our code simpler.
Remove splits from
paragraphs_to_deleteandsentences_to_deleteWe are always sending all splits, so we can reindex the entire field
Remove per-paragraph deletion from
paragraphs_to_deleteThis was started a few months ago and the changes are already propagated everywhere
Remove vectors on field deletion
When deleting a field,
delete_metadata()was called which deleted only from paragraph index, not vectors index.