Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GHA to Ubuntu 24 #2614

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Update GHA to Ubuntu 24 #2614

merged 1 commit into from
Nov 8, 2024

Conversation

javitonino
Copy link
Contributor

@javitonino javitonino commented Nov 8, 2024

This is happening: https://github.blog/changelog/2024-11-05-notice-of-breaking-changes-for-github-actions/

Better to update before we are forced to :)

This is specially relevant since we do the hack of compiling rust binaries in the GHA runner and the moving them inside the docker container, which requires that runner and dockerfile base image are somewhat synchronized (they need to have a compatible glibc version).

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.14%. Comparing base (73f215d) to head (08b88f3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2614      +/-   ##
==========================================
- Coverage   86.22%   86.14%   -0.09%     
==========================================
  Files         377      377              
  Lines       23786    23786              
==========================================
- Hits        20510    20490      -20     
- Misses       3276     3296      +20     
Flag Coverage Δ
nucliadb 73.68% <ø> (-0.08%) ⬇️
nucliadb-ingest 28.52% <ø> (ø)
nucliadb-reader 24.55% <ø> (ø)
nucliadb-search 37.60% <ø> (ø)
nucliadb-standalone 46.59% <ø> (ø)
nucliadb-train 44.72% <ø> (ø)
nucliadb-writer 39.14% <ø> (ø)
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 85.09% <ø> (ø)
nucliadb_sdk 80.11% <ø> (ø)
nucliadb_sidecar 87.24% <ø> (-1.79%) ⬇️
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 84.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javitonino javitonino merged commit 9fab332 into main Nov 8, 2024
53 checks passed
@javitonino javitonino deleted the ubuntu24-gha branch November 8, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants