Devmerge #2646
Merged
Devmerge #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate date filter test * Migrate more search tests * Copy remaining search tests: pending to implement suggest * Port suggest to nidx * Missing shard_suggest module * Add basic tests for shards with/without vectorsets * Implement add and list vectorsets * Remove unneeded allow * Remove rayon from relations and don't parallelize sugggest * Implement remove vectorsets * cargo fmt * Change error string Co-authored-by: Javier Torres <javier@javiertorres.eu> --------- Co-authored-by: Joan Antoni RE <joanantoni.re16@gmail.com>
* Convert ParagraphSearchRequest to SearchRequest * Return appropiate paragraph response * No more RelationSearch either * Not ready to replace paragraph search request * Don't call RelationSearch anymore (py) * Remove RelationSearch * Let's try again with paragraph search :) * Typo in type * Replace last direct call to ParagraphSearch (tests) * No more ParagraphSearch (grpc) * No more DocumentSearch * No more VectorSearch * Remove test using document search * Update protos * Fix test * Cleanup query_paragraph_shard * Remove ignored params from resource search endpoint * Fix test * Fix unit tests * Cleanup relations_shard * Remove paragraph and relation search methods
lferran
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.