Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant asyncio marks in tests and fixtures #2736

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

jotare
Copy link
Contributor

@jotare jotare commented Dec 16, 2024

Description

pytest's asyncio_mode is always set to auto. This means all async fixtures and tests are automatically annotated with pytest.mark.asyncio and we don't need to. In addition, fixtures annotated with this mark throw a noisy error on every test execution.

How was this PR tested?

Existing test suite

@jotare jotare requested a review from a team December 16, 2024 15:05
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (dac174f) to head (03e811c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2736      +/-   ##
==========================================
+ Coverage   86.76%   86.83%   +0.07%     
==========================================
  Files         383      383              
  Lines       24184    24200      +16     
==========================================
+ Hits        20983    21014      +31     
+ Misses       3201     3186      -15     
Flag Coverage Δ
nucliadb 74.54% <ø> (+0.07%) ⬆️
nucliadb-ingest 28.70% <ø> (ø)
nucliadb-reader 24.60% <ø> (ø)
nucliadb-search 38.06% <ø> (ø)
nucliadb-standalone 46.89% <ø> (ø)
nucliadb-train 45.45% <ø> (-0.03%) ⬇️
nucliadb-writer 38.98% <ø> (ø)
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 83.42% <ø> (ø)
nucliadb_sdk 80.11% <ø> (ø)
nucliadb_sidecar 89.03% <ø> (ø)
nucliadb_telemetry 86.56% <ø> (ø)
nucliadb_utils 83.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotare jotare merged commit 3d4a6dc into main Dec 17, 2024
64 checks passed
@jotare jotare deleted the pytest-asyncio-is-always-auto branch December 17, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants