Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not compute global text&tags twice on reindex #2761

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Dec 27, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Existing test suite

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (cf972d8) to head (ea66b10).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2761      +/-   ##
==========================================
+ Coverage   86.79%   86.83%   +0.04%     
==========================================
  Files         384      384              
  Lines       24300    24300              
==========================================
+ Hits        21091    21102      +11     
+ Misses       3209     3198      -11     
Flag Coverage Δ
nucliadb 74.65% <100.00%> (+0.06%) ⬆️
nucliadb-ingest 33.84% <100.00%> (ø)
nucliadb-reader 42.43% <100.00%> (ø)
nucliadb-search 43.48% <100.00%> (ø)
nucliadb-standalone 47.13% <100.00%> (ø)
nucliadb-train 45.39% <100.00%> (ø)
nucliadb-writer 39.29% <100.00%> (ø)
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 83.29% <ø> (ø)
nucliadb_sdk 80.11% <ø> (ø)
nucliadb_sidecar 89.03% <ø> (ø)
nucliadb_telemetry 86.56% <ø> (ø)
nucliadb_utils 83.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran requested a review from jotare December 27, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants