This repository has been archived by the owner on Oct 19, 2023. It is now read-only.
Implement end-to-end tDec flow #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nucypher-ts-demo-tdec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
piotr-roslaniec
force-pushed
the
tdec-poc
branch
from
f9ab037
to
e756bb8
Compare
piotr-roslaniec
force-pushed
the
tdec-poc
branch
from
e756bb8
to
d91fad8
Compare
KPrasch
reviewed
Jun 27, 2023
src/index.tsx
Outdated
| @@ -7,7 +7,7 @@ import App from "./App"; | |||
|
|
|||
| const config: Config = { | |||
| readOnlyChainId: Goerli.chainId, | |||
| networks: [Goerli] | |||
| networks: [Goerli], | |||
There was a problem hiding this comment.
Mumbai? What is this network intended to be used for?
There was a problem hiding this comment.
On Mumbai, fixed
KPrasch
approved these changes
Jun 27, 2023
derekpierre
reviewed
Jun 27, 2023
| comparator: '==', | ||
| value: ':userAddress', | ||
| comparator: ">", | ||
| value: "0", |
There was a problem hiding this comment.
Even though we use a string here, presumably a number is allowed?
There was a problem hiding this comment.
Yes, both should work fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StrategyBuilderhas been removed. We use a hard-coded ritual instead.