add TODOs

nucypher · Jun 22, 2023 · ccdeba0 · ccdeba0 · github-actions · Jun 22, 2023
1 parent b67cbc9
commit ccdeba0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 13 deletions.
diff --git a/src/characters/pre-recipient.ts b/src/characters/pre-recipient.ts
@@ -188,18 +188,13 @@ export class PreTDecDecrypter {
   public equals(other: PreTDecDecrypter): boolean {
     return (
       this.porter.porterUrl.toString() === other.porter.porterUrl.toString() &&
-      bytesEquals(
-        this.policyEncryptingKey.toCompressedBytes(),
-        other.policyEncryptingKey.toCompressedBytes()
-      ) &&
+      this.policyEncryptingKey.equals(other.policyEncryptingKey) &&
+      // TODO: Replace with `equals` after https://github.com/nucypher/nucypher-core/issues/56 is fixed
       bytesEquals(
         this.encryptedTreasureMap.toBytes(),
         other.encryptedTreasureMap.toBytes()
       ) &&
-      bytesEquals(
-        this.publisherVerifyingKey.toCompressedBytes(),
-        other.publisherVerifyingKey.toCompressedBytes()
-      )
+      this.publisherVerifyingKey.equals(other.publisherVerifyingKey)
     );
   }
 }
diff --git a/src/dkg.ts b/src/dkg.ts
@@ -86,7 +86,9 @@ export class DkgRitual {
   public equals(other: DkgRitual): boolean {
     return (
       this.id === other.id &&
+      // TODO: Replace with `equals` after https://github.com/nucypher/nucypher-core/issues/56 is fixed
       bytesEquals(this.dkgPublicKey.toBytes(), other.dkgPublicKey.toBytes()) &&
+      // TODO: Replace with `equals` after https://github.com/nucypher/nucypher-core/issues/56 is fixed
       bytesEquals(
         this.dkgPublicParams.toBytes(),
         other.dkgPublicParams.toBytes()

diff --git a/src/sdk/strategy/pre-strategy.ts b/src/sdk/strategy/pre-strategy.ts
@@ -128,7 +128,7 @@ export class PreStrategy {
   public equals(other: PreStrategy) {
     return (
       this.cohort.equals(other.cohort) &&
-      // TODO: Add equality to WASM bindings
+      // TODO: Replace with `equals` after https://github.com/nucypher/nucypher-core/issues/56 is fixed
       bytesEquals(
         this.aliceSecretKey.toBEBytes(),
         other.aliceSecretKey.toBEBytes()
@@ -201,10 +201,7 @@ export class DeployedPreStrategy {
     return (
       this.cohort.equals(other.cohort) &&
       this.decrypter.equals(other.decrypter) &&
-      bytesEquals(
-        this.policyKey.toCompressedBytes(),
-        other.policyKey.toCompressedBytes()
-      )
+      this.policyKey.equals(other.policyKey)
     );
   }
 }