Fix incorrect Condition parsing
#239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-roslaniec
commented
Jul 7, 2023
Comment on lines
-106
to
+108
| .map((condition) => JSON.parse(condition.toString())) | ||
| .reduce((acc: Record<string, string>[], val) => acc.concat(val), []); | ||
| .map((condition) => ConditionExpression.fromJSON(condition.toString())) | ||
| .reduce((acc: ConditionExpression[], val) => acc.concat(val), []) | ||
| .map((condExpr: ConditionExpression) => condExpr.condition); |
There was a problem hiding this comment.
This out-of-date condition handling was the root cause
Codecov Report
@@ Coverage Diff @@
## beta #239 +/- ##
==========================================
+ Coverage 83.47% 83.66% +0.18%
==========================================
Files 37 37
Lines 968 967 -1
Branches 121 121
==========================================
+ Hits 808 809 +1
+ Misses 154 152 -2
Partials 6 6
|
theref
approved these changes
Jul 7, 2023
manumonti
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
ConditionContextattempting to accessundefinedfieldsConditionContextis prepared for Porter to fix this issue passing silently in testsWhy it's needed:
Notes for reviewers:
alphatree