-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace variant
parameter with a default FerveoVariant.Simple
#262
Conversation
752320c
to
36fd43e
Compare
Bundled size for the package is listed below: build/module/src/kits: 19.53 KB |
Codecov Report
@@ Coverage Diff @@
## alpha #262 +/- ##
==========================================
+ Coverage 80.35% 80.54% +0.18%
==========================================
Files 36 36
Lines 1008 987 -21
Branches 116 110 -6
==========================================
- Hits 810 795 -15
+ Misses 190 184 -6
Partials 8 8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎸 - thanks for taking care of this!
import { ethers } from 'ethers'; | ||
|
||
import { DkgCoordinatorAgent, DkgRitualState } from './agents/coordinator'; | ||
import { ChecksumAddress } from './types'; | ||
import { fromHexString, objectEquals } from './utils'; | ||
|
||
export function getVariantClass( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Type of PR:
Required reviews:
What this does:
FerveoVariant
from user-facing APIFerveoVariant.Simple
as the default variantIssues fixed/closed:
FerveoVariant.Simple
by default #248