Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace variant parameter with a default FerveoVariant.Simple #262

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

piotr-roslaniec
Copy link
Contributor

Type of PR:

  • Feature

Required reviews:

  • 1

What this does:

  • Hides FerveoVariant from user-facing API
  • Sets FerveoVariant.Simple as the default variant

Issues fixed/closed:

@github-actions
Copy link

Bundled size for the package is listed below:

build/module/src/kits: 19.53 KB
build/module/src/characters: 74.22 KB
build/module/src/policies: 19.53 KB
build/module/src/agents: 39.06 KB
build/module/src/conditions/predefined: 19.53 KB
build/module/src/conditions/base: 54.69 KB
build/module/src/conditions/context: 42.97 KB
build/module/src/conditions: 156.25 KB
build/module/src/sdk/strategy: 31.25 KB
build/module/src/sdk: 42.97 KB
build/module/src: 425.78 KB
build/module/types/ethers-contracts/factories: 82.03 KB
build/module/types/ethers-contracts: 152.34 KB
build/module/types: 156.25 KB
build/module: 636.72 KB
build/main/src/kits: 19.53 KB
build/main/src/characters: 74.22 KB
build/main/src/policies: 19.53 KB
build/main/src/agents: 39.06 KB
build/main/src/conditions/predefined: 19.53 KB
build/main/src/conditions/base: 54.69 KB
build/main/src/conditions/context: 42.97 KB
build/main/src/conditions: 156.25 KB
build/main/src/sdk/strategy: 35.16 KB
build/main/src/sdk: 46.88 KB
build/main/src: 433.59 KB
build/main/types/ethers-contracts/factories: 82.03 KB
build/main/types/ethers-contracts: 152.34 KB
build/main/types: 156.25 KB
build/main: 644.53 KB
build: 1.26 MB

@codecov-commenter
Copy link

Codecov Report

Merging #262 (36fd43e) into alpha (e4f824d) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            alpha     #262      +/-   ##
==========================================
+ Coverage   80.35%   80.54%   +0.18%     
==========================================
  Files          36       36              
  Lines        1008      987      -21     
  Branches      116      110       -6     
==========================================
- Hits          810      795      -15     
+ Misses        190      184       -6     
  Partials        8        8              
Files Changed Coverage Δ
src/characters/cbd-recipient.ts 92.59% <100.00%> (-0.63%) ⬇️
src/dkg.ts 28.20% <100.00%> (-9.98%) ⬇️

Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸 - thanks for taking care of this!

import { ethers } from 'ethers';

import { DkgCoordinatorAgent, DkgRitualState } from './agents/coordinator';
import { ChecksumAddress } from './types';
import { fromHexString, objectEquals } from './utils';

export function getVariantClass(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@piotr-roslaniec piotr-roslaniec merged commit 75fa0f0 into alpha Aug 14, 2023
12 checks passed
@piotr-roslaniec piotr-roslaniec deleted the set-default-variant branch August 14, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

4 participants