Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update taco-web demos to use latest released version of taco, taco-auth #578

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

derekpierre
Copy link
Member

@derekpierre derekpierre commented Sep 4, 2024

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR. List relevant API
changes (if any), as well as related PRs and issues.

Update taco-web demos to use latest released versions of @nucypher/taco and @nucypher/taco-auth.

Issues fixed/closed:

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network. E.g.,
if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on? Is there a particular commit/function/section
of your PR that requires more attention from reviewers?

@derekpierre derekpierre changed the title [WIP] Update taco demos to use latest released version of taco, taco-auth [WIP] Update taco-web demos to use latest released version of taco, taco-auth Sep 4, 2024
Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for taco-nft-demo ready!

Name Link
🔨 Latest commit 78a0b8e
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/66d8a9edc9541e000884fbd7
😎 Deploy Preview https://deploy-preview-578--taco-nft-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for taco-demo ready!

Name Link
🔨 Latest commit 78a0b8e
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/66d8a9ed49c5090008455933
😎 Deploy Preview https://deploy-preview-578--taco-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.44%. Comparing base (e8f9098) to head (78a0b8e).
Report is 205 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #578       +/-   ##
===========================================
+ Coverage   23.12%   88.44%   +65.31%     
===========================================
  Files          62       59        -3     
  Lines       10175     6075     -4100     
  Branches      260      148      -112     
===========================================
+ Hits         2353     5373     +3020     
+ Misses       7763      702     -7061     
+ Partials       59        0       -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derekpierre derekpierre changed the title [WIP] Update taco-web demos to use latest released version of taco, taco-auth Update taco-web demos to use latest released version of taco, taco-auth Sep 4, 2024
@derekpierre derekpierre marked this pull request as ready for review September 4, 2024 18:52
@theref theref merged commit 58a14c3 into nucypher:main Sep 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants