Initial Implementation of SequentialCondition
#581
+565
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… This is not directly exported, but is used internally by other conditions. Update compound condition to use common condition schema.
… building blocks.
…s; It would be nice to have something common like this but I'm not sure how to do that currently. Explicitly define union of all conditions in compound and sequential modules.
…ted sequential conditions.
derekpierre
force-pushed
the
sequential-condition
branch
from
338536f
to
dd236ea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## epic-sequential-condition #581 +/- ##
============================================================
Coverage ? 89.32%
============================================================
Files ? 61
Lines ? 6230
Branches ? 330
============================================================
Hits ? 5565
Misses ? 664
Partials ? 1 ☔ View full report in Codecov by Sentry. |
…not provided for conditionVariables.
derekpierre
changed the title
derekpierre
requested review from
KPrasch,
arjunhassard,
cygnusv,
theref,
vzotova and
manumonti
derekpierre
changed the title
SequentialCondition
vzotova
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Implementation of SequentialCondition from nucypher/nucypher#3500
Issues fixed/closed:
Why it's needed:
Notes for reviewers: