-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implementation of IfThenElseCondition
#593
Merged
derekpierre
merged 5 commits into
nucypher:epic-v0.6.x
from
derekpierre:if-then-else-condition
Oct 16, 2024
Merged
feat: implementation of IfThenElseCondition
#593
derekpierre
merged 5 commits into
nucypher:epic-v0.6.x
from
derekpierre:if-then-else-condition
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekpierre
force-pushed
the
if-then-else-condition
branch
from
October 8, 2024 16:06
b3df1c2
to
1f53a4d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## epic-v0.6.x #593 +/- ##
==============================================
Coverage ? 89.18%
==============================================
Files ? 73
Lines ? 6490
Branches ? 170
==============================================
Hits ? 5788
Misses ? 702
Partials ? 0 ☔ View full report in Codecov by Sentry. |
derekpierre
changed the title
[WIP] feat: implementation of
feat: implementation of Oct 9, 2024
IfThenElseCondition
IfThenElseCondition
derekpierre
requested review from
KPrasch,
cygnusv,
theref,
vzotova and
manumonti
October 9, 2024 17:20
derekpierre
force-pushed
the
epic-v0.6.x
branch
2 times, most recently
from
October 10, 2024 17:41
bfef228
to
2a51cac
Compare
derekpierre
force-pushed
the
if-then-else-condition
branch
from
October 10, 2024 17:44
1f53a4d
to
5bac8b7
Compare
manumonti
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const lgtm = True
const approved = True
const elseCondition = False
const condition = new IfThenElseCondition({
ifCondition: lgtm,
thenCondition: approved,
elseCondition: elseCondition,
});
derekpierre
force-pushed
the
if-then-else-condition
branch
from
October 15, 2024 12:43
5bac8b7
to
92f76b8
Compare
vzotova
approved these changes
Oct 15, 2024
derekpierre
force-pushed
the
epic-v0.6.x
branch
from
October 15, 2024 19:34
5afedd8
to
7f30464
Compare
derekpierre
force-pushed
the
if-then-else-condition
branch
from
October 15, 2024 19:35
bda7227
to
24a5e62
Compare
…` (nodes) are also valid in `taco-web` (client library).
derekpierre
force-pushed
the
if-then-else-condition
branch
from
October 16, 2024 12:14
24a5e62
to
bf85a9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Based over #591 .
Initial implementation of
IfThenElseCondition
.Issues fixed/closed:
Related to nucypher/nucypher#3558.
Why it's needed:
Notes for reviewers: