Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementation of IfThenElseCondition #593

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

derekpierre
Copy link
Member

@derekpierre derekpierre commented Oct 7, 2024

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:
Based over #591 .

Initial implementation of IfThenElseCondition.

Issues fixed/closed:
Related to nucypher/nucypher#3558.

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network. E.g.,
if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on? Is there a particular commit/function/section
of your PR that requires more attention from reviewers?

@derekpierre derekpierre mentioned this pull request Oct 7, 2024
16 tasks
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (epic-v0.6.x@7f30464). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             epic-v0.6.x     #593   +/-   ##
==============================================
  Coverage               ?   89.18%           
==============================================
  Files                  ?       73           
  Lines                  ?     6490           
  Branches               ?      170           
==============================================
  Hits                   ?     5788           
  Misses                 ?      702           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derekpierre derekpierre changed the title [WIP] feat: implementation of IfThenElseCondition feat: implementation of IfThenElseCondition Oct 9, 2024
@derekpierre derekpierre marked this pull request as ready for review October 9, 2024 17:20
@derekpierre derekpierre self-assigned this Oct 9, 2024
@derekpierre derekpierre force-pushed the epic-v0.6.x branch 2 times, most recently from bfef228 to 2a51cac Compare October 10, 2024 17:41
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const lgtm = True
const approved = True
const elseCondition = False

const condition = new IfThenElseCondition({
      ifCondition: lgtm,
      thenCondition: approved,
      elseCondition: elseCondition,
});

…` (nodes) are also valid in `taco-web` (client library).
@derekpierre derekpierre merged commit fcdb1da into nucypher:epic-v0.6.x Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants