Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: include taco-auth in api docs #594

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

derekpierre
Copy link
Member

@derekpierre derekpierre commented Oct 7, 2024

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

Noticed while working on TACo docs that taco-auth is not included in published docs for taco-web.

Docs are now updated. See https://nucypher.github.io/taco-web/.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network. E.g.,
if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on? Is there a particular commit/function/section
of your PR that requires more attention from reviewers?

At @ts-expect-error annotation so that docs can build.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (epic-v0.6.x@9fa5ffa). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             epic-v0.6.x     #594   +/-   ##
==============================================
  Coverage               ?   88.83%           
==============================================
  Files                  ?       62           
  Lines                  ?     6290           
  Branches               ?      335           
==============================================
  Hits                   ?     5588           
  Misses                 ?      664           
  Partials               ?       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derekpierre derekpierre mentioned this pull request Oct 7, 2024
16 tasks
@derekpierre derekpierre self-assigned this Oct 7, 2024
@derekpierre derekpierre marked this pull request as ready for review October 7, 2024 20:18
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I didn't know about this 🤯 https://nucypher.github.io/taco-web/

typedoc.json Outdated Show resolved Hide resolved
@derekpierre derekpierre merged commit 58e4031 into nucypher:epic-v0.6.x Oct 8, 2024
4 checks passed
derekpierre added a commit that referenced this pull request Oct 10, 2024
derekpierre added a commit that referenced this pull request Oct 10, 2024
derekpierre added a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants