Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC for Encryptor Signature Self-Delegation Authentication #601

Draft
wants to merge 5 commits into
base: epic-v0.6.x
Choose a base branch
from

Conversation

cygnusv
Copy link
Member

@cygnusv cygnusv commented Nov 1, 2024

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR. List relevant API
changes (if any), as well as related PRs and issues.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network. E.g.,
if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on? Is there a particular commit/function/section
of your PR that requires more attention from reviewers?

@cygnusv cygnusv changed the base branch from main to epic-v0.6.x November 1, 2024 22:23
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for taco-nft-demo canceled.

Name Link
🔨 Latest commit 80290b0
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/672554d951942f000853bb63

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for taco-demo canceled.

Name Link
🔨 Latest commit 80290b0
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/672554d9255d300008882d9d

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (epic-v0.6.x@8a7e72d). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             epic-v0.6.x     #601   +/-   ##
==============================================
  Coverage               ?   89.30%           
==============================================
  Files                  ?       74           
  Lines                  ?     6565           
  Branches               ?      178           
==============================================
  Hits                   ?     5863           
  Misses                 ?      702           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cygnusv cygnusv force-pushed the reuse branch 3 times, most recently from c4f3019 to 098c4f5 Compare November 4, 2024 16:41
Normally, we would use ETH-based signers, but in principle anything that's a PK signer should work.
This means, they already include the self-delegation authorization from the encryptor
This currently works with tapir ritual 6, but only because it uses OpenAccessAuthorizer. In reality, this will fail with GlobalAllowList since this needs proper validation of evidence authorization.
This commit should be deleted before merging the PR, it's just illustrative
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants