Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blood: Fix tiles broken from recompression attempts #844

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

tmyqlfpir
Copy link
Contributor

This PR fixes errors for tiles 9218 and 9219 introduced in #687 and #779.

Comparing to the original tiles before these two PRs, I compared the files by using a difference filter in photoshop and increased the brightness to exaggerate the pixels that differ.

Original vs after PR #779
originalcompressed

Difference
current

Original vs after PR #779
original
compressed

Difference
difference

I went through and recompressed all tiles by using the original images before PR #687. PNGOUT and ECT were both used.
The commands to compressed the images are as follows

pngout /f0 /b128 /kt /k0 /v /y
ect -9 -strip -keep --pal_sort=120 --allfilters
pngout /f0 /b128 /kt /k0 /v /y

@Hendricks266 Hendricks266 merged commit fee9883 into nukeykt:master Sep 7, 2024
10 checks passed
@tmyqlfpir tmyqlfpir deleted the fix-pk3 branch September 8, 2024 00:11
@Oplexitie
Copy link
Contributor

Went back and checked the assets of the other pk3's just to be sure this didn't affect them.
Thankfully, this only affected the Blood assets that the op mentioned.

Spent a few hours figuring out what happened. The affected assets used PNGQUANT (a lossy image compressor), and I included them by accident. Apologies for my blunder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants