Update ansi.c to use eeconfig_read_user_datablock for air75_v2 (and maybe other versions?) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it compile ok for me. I am not entirely sure why, but I think it makes sense to load the config using this function, same as the halo95 code? https://github.com/venetanji/qmk_firmware/blob/ec8b9fb2cdc0e7d97166e4edd57ae5c52bc3cdaa/keyboards/nuphy/halo96_v2/ansi/ansi.c#L716
|
It looks like the |
|
Yeah that branch worked fine for my air 75 v2. I was able to map a midi layer 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it compile ok for me. I am not entirely sure why, but I think it makes sense to load the config using this function, same as the halo95 code? https://github.com/venetanji/qmk_firmware/blob/ec8b9fb2cdc0e7d97166e4edd57ae5c52bc3cdaa/keyboards/nuphy/halo96_v2/ansi/ansi.c#L716
Description
Got the keyboard yesterday, I managed to compile working firmware with this change.
Qmk compile threw an error about
eeconfig_read_kb_datablockTypes of Changes
Issues Fixed or Closed by This PR
Fixes compilation errors for air75_v2