Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T13-3] JxMusic #116

Open
wants to merge 411 commits into
base: master
Choose a base branch
from

Conversation

handshou
Copy link

@handshou handshou commented Oct 5, 2018

@hidingmode @HaydenPhillips @NancyQuris @Gongjie663746

JxMusic v1.1 changelog:

  • Add play command to play 1 hardcoded track in the /library folder
  • Add pause command to pause the track
  • Add stop command to stop the track
    The 3 commands are only working on Windows for now, not working on Mac OS. We are planning to resolve the issue by v1.2.

Copy link

@parvathy-sudhir-pillai parvathy-sudhir-pillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Overall
Good start, Team. However, some areas need more work. Hope you can tackle those areas in upcoming features.

You seem to have a lot of features. Make sure that you scope out your work properly for each version.
You can consider skipping some of the less important features or push to v2.0.

Some detailed feedback:

  • ReadMe adoc
  1. Homepage still has AB-4 as the product name.
  2. Travis build status badge should point to the build status of your own repo, not se-edu/AB-4.
    Other badges should be updated to match their project or removed.
  3. Update product description. Still refers to AB-4
  4. AB-4 should be acknowledged in the Acknowledgements section
  • Contact Us adoc
  1. Update details and links
  • About Us adoc
  1. Roles and components must be assigned to members
  • UserGuide adoc
  1. Update By: Since: at the beginning of the page
  2. Update Introduction and Quick Start sections to reflect your product's
  • DeveloperGuide adoc
  1. Update Product Scope and value proposition to be your product's
  2. Grammar check on Use cases
  3. Update NFR and Glossary

@@ -4,7 +4,7 @@
:imagesDir: images
:stylesDir: stylesheets

AddressBook - Level 4 was developed by the https://se-edu.github.io/docs/Team.html[se-edu] team. +
JxMusic(AddressBook - Level 4) was developed by the CS2103-Ay1819S1-T13-3 developer (are we supposed to add links) (https://se-edu.github.io/docs/Team.html[se-edu]) team. +

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What links? Add your portfolio and GitHub links only for now

1. User requests to list all the playlists.
2. System displays names of all playlists in the library.
+
Use case ends.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No extensions? What if there are no playlists?

*Extensions*

[none]
* 4a. There is no list matches the name.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No list matches the name.

Copy link

@parvathy-sudhir-pillai parvathy-sudhir-pillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback for v1.2

  • Can update the GitHub link to your product webpage instead of AB-4:
    t13-1

Contact Us

  • Update issue tracker link

User guide

  • Update commands/descriptions that refer to AB-4 rather than your app's. For e.g.
    t13-2
  • Examples should be realistic
    t13-3

Developer guide

  • No significant updates from previous milestone
  • Not enough new/updated design descriptions and UML diagrams to give feedback on. Please try to add more soon.
  • Keep in mind that we discourage low level diagrams that span multiple components. Try to draw diagrams at multiple levels: one that shows component level interactions and others shown low level interactions within one components.

Overall

Work on making the product user-testable soon, and catch up on documentation work. The progress at the moment, at least w.r.t documentation seems a bit behind what is required at this stage 😟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants