-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Quek Sze Long] iP #465
Open
szelongq
wants to merge
59
commits into
nus-cs2103-AY2122S1:master
Choose a base branch
from
szelongq:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Quek Sze Long] iP #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add greetings when starting Duke. Add echoing of user input. Add exiting of program on entering "bye".
Add accepting and storing user inputted tasks into a list. Add listing all tasks in the list.
Add Task class. Add ability to mark tasks as done.
Add support for 3 types of tasks: ToDo, Deadline, Event.
Add Exception checking for missing input for adding tasks. Add Exception checking for unsupported operations.
Add ability to delete tasks from the list.
Fix Deadline tasks being created as Event tasks instead. Update ToDo, Deadline and Event class constructors to set whether the task is done according to input. Update Task Class to be abstract.
Add ability to save and load tasks on the hard drive.
Add ability to read and print dates for Deadline and Event tasks.
Update the loading of saved tasks to parse dates.
Improve OOP.
Move all classes into duke package.
Add JUnit Tests for TaskList and Parser classes.
Add Javadoc comments for some of the classes.
Edit some code to conform to CS2103T Coding Standard.
Add ability to find tasks by searching with a keyword.
twothicc
reviewed
Aug 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Only some recommended changes related to coding standard.
cookiedan42
reviewed
Aug 31, 2021
Update code to follow coding standards better. Add more comments to some methods for clarity of code function.
Use Gradle.
Rectify coding violations found by checkStyle.
Add a GUI using JavaFX. Remove text-based UI.
There are several methods that convert a collection to a set. In somerrr There are a number of assumptions made in the code about the program's flow of control and input of certain non-public methods. These assumptions are not checked and could potentially lead to bugs that are hidden in the program. Let's use assertions to document these important assumptions that should hold true during execution of the code. Assertions do not have a heavy impact on performance and allows quick detection of bugs arising from the assumptions made in the code. They also help to document some of the logic in the code and improves maintainability of the program.
The parseNewTask method is considerably long. Long methods are harder to read. Bugs are also harder to find in long methods. Let's move the parsing of TaskType from a String object into a new method in TaskType class. This would reduce the length of the parseNewTask method, making it easier to read and understand. It would also allow other future classes to use the method as well.
The loadTasks method is too long. Let's move the parsing of a single saved task into a new loadTask method. This would result in two shorter and more readable methods.
Break up lines in DialogBox class. Introduce more intermediate variables to improve readability and explicitness of code in Parser and Storage classes.
Use assertions in code
Improve code quality
Add new workflow to the project.
Set up workflow for continuous integration
Add two new commands: showpath and setpath.
Add extension for flexible data source
Change display pictures for Duke and User. Add product name in the title bar of the GUI window. Add bordering and background to messages.
Improve GUI
Rebrand Duke as Tipsy
Rebrand Duke as Tipsy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tipsy
Tipsy frees your drunk mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is,
And it is FREE!
Features:
If you are a Java programmer, you can use it to practice Java too. Here's the
main
method: