-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wang Guanlin] iP #468
Open
WangGLJoseph
wants to merge
86
commits into
nus-cs2103-AY2122S1:master
Choose a base branch
from
WangGLJoseph:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Wang Guanlin] iP #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ects instead of an ArrayList of String(s)
…automate the testing of Duke
* 'master' of https://github.com/WangGLJoseph/ip: Update README.md Update README.md
* branch-Level-10: Level-10: Add GUI for Duke Create new package for controllers Extract GUI logic out of Duke and into Main Add DukeLauncher as part of JavaFX basics
The addTask method implements the addition of multiple types of tasks (i.e. ToDo, Deadline, Event). This violates the Single Level of Abstraction principle and makes the code difficult to understand or debug. Implementing the add task methods separately allows us to call different methods when adding a task of a particular type (e.g. addTodo). Let's implement addTodo, addDeadline, and addEvent as separate methods. This reduces the risk of calling the wrong add task method.
The parse method implements the parsing of all data from duke.txt into an ArrayList. The method handles the parsing of all types of tasks. This violates the Single Level of Abstraction principle and makes the code difficult to understand or debug. Implementing each parse task methods separately allows us to call different methods when parsing one type of task (e.g. addTodo). Let's implement parseTodo, parseDeadline, and parseEvent as separate methods. This reduces the risk of calling the wrong parse task method.
Add assertions for key assumptions in the code
* 'master' of https://github.com/WangGLJoseph/ip: Add assertions for key assumptions in the code
* master: Add assertions for key assumptions in the code
Apply SLAP to TaskList and DukeParser
* 'master' of https://github.com/WangGLJoseph/ip: DukeParser class: Apply SLAP to shorten methods of parsing data Remove data within data/duke.txt Update .gitignore to ignore data/duke.txt TaskList class: Apply SLAP to shorten methods of adding tasks Update DialogBox to display more text Update method header comments to follow the coding standard
* 'master' of https://github.com/WangGLJoseph/ip: Set theme jekyll-theme-time-machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duke v0.9.0
Duke offers you a:
and completely offline experience of planning your tasks!
Duke's features
Setting up Duke
A snippet of the workings of controlling your tasks. Behold, you've got the power!