[Lulu Y] iP #473

luluyousef · 2021-08-26T11:41:21Z

DukePro

“Your mind is for having ideas, not holding them.” – David Allen (source)

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

Joel-Sung

Overall, your code quality is pretty good in my opinion. Just some things to take note, I think you should start adding spaces within your statements as it is part of the Java coding standard. Maybe also consider declaring class variables as private, unless you have a reason to do otherwise.

Joel-Sung · 2021-08-31T06:50:31Z

src/main/java/Duke.java

+                f.createNewFile();
+            }
+            Scanner sc = new Scanner(f);
+            ArrayList<Task> t = new ArrayList<>();


I am not sure I like the name of the ArrayList. I think giving it a clearer name would improve the readability of your code. For example, 'taskList'.

Joel-Sung · 2021-08-31T06:55:52Z

src/main/java/Duke.java

+            int ctr = 0;
+            Scanner scanner = new Scanner(System.in);
+            System.out.println("_______________________________________________");
+            System.out.println("Hello! I'm Duke\n" + "What can I do for you?");


I think placing a line break before the '+' would improve improve the readability of your code. This is because you add a next line character before the '+', so presenting your code in the same way the output will look would be nice.

Joel-Sung · 2021-08-31T06:57:56Z

src/main/java/Duke.java

+                    System.out.println(d.getMessage());
+                }
+            }
+        }catch(IOException e){


I think you may have missed this. Add a space between the } and catch.

Joel-Sung · 2021-08-31T07:05:52Z

src/main/java/Duke.java

+                    text = text.concat("0|");
+                }
+                text = text.concat(t.description + "|" + ((Event) t).by + "\n");
+            }


I think it is better to add a space around every 'if', 'else' and 'for' as this helps the readability of your code.

Joel-Sung · 2021-08-31T07:08:19Z

src/main/java/DukeException.java

@@ -0,0 +1,5 @@
+public class DukeException extends Exception{


I think you should add a space after Exception. I noticed that this is a recurring practice for your classes. Adding a space between the class declaration and the { will help to add readability to your code. I suggest you read the part on "White space within a statement" in the Java coding standard 😄 .

Joel-Sung · 2021-08-31T07:10:04Z

src/main/java/Event.java

@@ -0,0 +1,15 @@
+public class Event extends Task{
+
+    protected String by;


I think it would be better to keep your class variables as private. Do you have a reason to declare them as protected?

tchiong

Other than the comments from the other reviewers and myself, LGTM!

tchiong · 2021-09-04T14:37:20Z

src/main/java/Deadline.java

+import java.time.LocalDateTime;
+import java.time.format.DateTimeFormatter;
+
+public class Deadline extends Task{


Could perhaps add header docs to the class!

tchiong · 2021-09-04T14:38:02Z

src/main/java/Duke.java

+            }
+            int ctr = 0;
+            Scanner scanner = new Scanner(System.in);
+            System.out.println("_______________________________________________");


Can perhaps use a function to print the dividers to make the code look more readable!

Certain Assumptions in the code needs to be verified. Let's utilize Java Assertions and use the keyword assert to verify assumptions in the code.

Branch A assertion

Long methods are hard to read and affect code quality. Let's follow the coding standards and break long methods by refractoring.

Some methods in the code are too long in the Parser and Storage class.

damithc and others added 8 commits July 29, 2021 20:30

Add Gradle support

d839859

Greet, Echo, and Exit

661654c

Add and List

b0037be

Added ability to mark tasks as done.

8c89dc5

Added support for tracking todo, deadlines, and events

fad94ab

Automated Text UI Testing

cf8150a

Handled user input errors

d66b802

Added deleting task from the list.

7b3a3ea

luluyousef changed the title ~~Lulu Y~~ [Lulu Y] iP Aug 26, 2021

luluyousef added 2 commits August 26, 2021 23:48

Complete level 7.

1385ef2

Level 8

0b59ceb

Joel-Sung reviewed Aug 31, 2021

View reviewed changes

tchiong reviewed Sep 4, 2021

View reviewed changes

luluyousef and others added 17 commits September 5, 2021 00:44

Use More OOP

8a580c2

Organize into package duke

3658c71

Add JUnit tests

aace4c9

Package app as a JAR file

a0d5982

Add JavaDoc comments

96f9d69

Tweak Code to comply with coding standard

2b3acec

Implement Level 9

d00efa7

Task file

ee836cd

tasks

70f9441

Merge branch 'branch-A-JavaDoc'

dd6bf47

Merge remote-tracking branch 'origin/add-gradle-support'

e2eb3f8

Automate project builds using Gradle

a0ab049

Use Checkstyle

18b246f

Add a GUI to Duke.

53e21c5

The code does not have any assertions.

d7cf635

Certain Assumptions in the code needs to be verified. Let's utilize Java Assertions and use the keyword assert to verify assumptions in the code.

Merge pull request #2 from luluyousef/branch-A-Assertion

06ed319

Branch A assertion

Merge branch 'master' of https://github.com/luluyousef/ip

c371ad6

luluyousef and others added 10 commits September 20, 2021 19:49

Some methods in the code are too long in the Parser and Storage class.

056aa5d

Long methods are hard to read and affect code quality. Let's follow the coding standards and break long methods by refractoring.

Merge pull request #3 from luluyousef/branch-A-CodeQuality

7a673ec

Some methods in the code are too long in the Parser and Storage class.

Merge branch 'master' of https://github.com/luluyousef/ip

4795a70

Improve the GUI

eae433b

Add C-Sort extension and fix loading issue in the Storage class

4a41bc0

Add a User Guide to the Project

9e1f4e2

Add Ui Image

2b25d9b

Fix User Guide

2f4be6b

no message

eaf0b08

Fix DeleteCommand and Finalize Project

6268a75

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lulu Y] iP #473

[Lulu Y] iP #473

luluyousef commented Aug 26, 2021 •

edited

Loading

Joel-Sung left a comment

Joel-Sung Aug 31, 2021

Joel-Sung Aug 31, 2021

Joel-Sung Aug 31, 2021

Joel-Sung Aug 31, 2021

Joel-Sung Aug 31, 2021

Joel-Sung Aug 31, 2021

tchiong left a comment

tchiong Sep 4, 2021

tchiong Sep 4, 2021

		@@ -0,0 +1,5 @@
		public class DukeException extends Exception{

		@@ -0,0 +1,15 @@
		public class Event extends Task{

		protected String by;

[Lulu Y] iP #473

Are you sure you want to change the base?

[Lulu Y] iP #473

Conversation

luluyousef commented Aug 26, 2021 • edited Loading

DukePro

Joel-Sung left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tchiong left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luluyousef commented Aug 26, 2021 •

edited

Loading