[Saketh] iP #484

loose-bus-change · 2021-08-27T01:43:17Z

Duke

Your own personal task recording system

“Your mind is for having ideas, not holding them.” – David Allen

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ EXTREMELY FAST to use

In order to access it:

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

This is a sample task list that you can view if you type the list command:
[D][ ] return book by: 2019-12-02
[E][ ] meeting at: 2015-10-15
[E][X] project meeting at: 2015-10-15

Here is the main method of the application:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

Merged Level-7

Committing the javadoc branch

Merging the Level 9 branch

gordonlzy

LGTM, just a few nitpicks

gordonlzy · 2021-09-01T00:33:03Z

src/main/java/duke/Parser.java

+ s.appendListToFile(t);
+ } else if (input.startsWith("find")) {
+ String keyword = input.substring(5);
+ ArrayList<Task> output = new ArrayList<>();


Perhaps the usage of plural form for output will work better?

I think the variable name should be completely renamed. The queried tasks aren't an "output"; they are the result of a query, and are then reformatted into a text result that gets printed.

gordonlzy · 2021-09-01T00:37:13Z

src/main/java/Duke.java

+ private Storage storage;
+ private TaskList tasks;
+ private File
+ file;


Any reason why you put file on the next line?

gordonlzy · 2021-09-01T00:45:13Z

src/main/java/Duke.java

@@ -1,10 +1,53 @@
+import duke.*;


Would it be better to list all the imported classes?

I concur with @gordonlzy. I think this violates one of the coding standards.

I agree as well. Imports should be one at a time.

gordonlzy · 2021-09-01T00:48:20Z

src/main/java/duke/Parser.java

+ * @param s The Storage that handles the reading and writing to a text file
+ * @param file The file that gets written to and read from
+ *
+ * @return void


Is it necessary to add @return for void?

wilburrito

LGTM, but just a few nits to fix, that's all.

wilburrito · 2021-09-01T11:22:25Z

src/main/java/Duke.java

@@ -1,10 +1,53 @@
+import duke.*;


I concur with @gordonlzy. I think this violates one of the coding standards.

wilburrito · 2021-09-01T11:24:24Z

src/main/java/duke/Parser.java

+ * Method that adds a Deadline task onto TaskList
+ *
+ * @param input The string that contains the user input
+ * @param t The TaskList that contains the tasks to be added


perhaps the naming of some of the parameters could be more verbose; however this is just nitpicky, since your javadocs already explain what the parameters mean. Good work! 👍🏻

wilburrito · 2021-09-01T11:26:13Z

src/main/java/duke/TaskList.java

+ * @param date The date mentioned in the task initialization.
+ *
+ *
+ * @return void


I'm not sure if this is necessary for a void method.

Merge add-gradle-support

JasonC01

LGTM:)!! Great work overall!

JasonC01 · 2021-09-03T17:47:01Z

src/main/java/duke/Deadline.java

+import java.time.format.DateTimeFormatter;
+
+public class Deadline extends Task {
+ protected LocalDate by;


In my opinion, deadline seems to be a better name compared to by

Smanmos

Quite good overall, but many parts could be improved

Smanmos · 2021-09-05T12:51:36Z

src/main/java/duke/DukeException.java

+class NullTaskError extends DukeException {
+ public NullTaskError() {
+ super("OOPS!!! The description of a todo cannot be empty.");
+ }


I think it would be better for type to be in the constructor instead of the getMsg method.

Smanmos · 2021-09-05T13:07:19Z

src/main/java/Duke.java

@@ -1,10 +1,53 @@
+import duke.*;


I agree as well. Imports should be one at a time.

Smanmos · 2021-09-05T13:07:53Z

src/main/java/Duke.java

+ private TaskList tasks;
+ private File
+ file;
+ private Parser p;


Avoid one letter names; parser would be a better name

Smanmos · 2021-09-05T13:21:38Z

src/main/java/duke/Parser.java

+ String year = breakingDate[2];
+ String month = breakingDate[1];
+ String currentDate = breakingDate[0];
+ int i = Integer.parseInt(currentDate);
+ if (i < 10) {
+ currentDate = "0" + currentDate;
+ }
+ String finalDateFormat = year + "-" + month + "-" + currentDate;
+ LocalDate date1 = LocalDate.parse(finalDateFormat);


Can be simplified using method LocalDate.of

Smanmos · 2021-09-05T13:25:49Z

src/main/java/duke/Ui.java

+
+public class Ui {
+ Scanner scan;
+ private String str;


Could be more descriptive; what String is str holding?

The reading from file method does not check whether the current task is done or not This needs to change so that the done nature of the task can be viewed by user The method of string manipulation has been updated to include this change Now every time the user asks for the list, the tasks that are marked done will be reflected as such in the output

Added assertions to the code This ensures that there are no unexpected errors in the code during running It is being fixed by adding relevant asserts statements in methods where applicable

Finish A-Assertions

Finish-A-CodeQuality

damithc and others added 22 commits July 29, 2021 20:30

Add Gradle support

d839859

Finished Level-1

4d0258b

Finished Level-2

916e1a4

Finished Level-3

9ee2158

Finished Level-4

6a59fbe

Finished A-TextUiTesting

ad750b7

Finished Level-5

35ab331

Finished Level-6

32dfefd

Finished Level-7

e5200af

Finished Level-8

2fa7e3c

Merge branch 'branch-Level-7'

250c123

Merged Level-7

Finished Level-8

23f2c19

Finished A-More-OOP

0879b67

Finished A-Packages

ae519f8

Finished JUnit Testing

86b9868

Finished A-Jar

3281b26

Finish branch-A-JavaDoc

b087b26

Finish A-CodingStandard

c907c92

Finish branch-Level-9

3333058

Merge branch 'branch-A-JavaDoc'

0cad0cf

Committing the javadoc branch

Finish A-CodingStandard

4784c9a

Merge branch 'branch-Level-9'

43952bf

Merging the Level 9 branch

gordonlzy reviewed Sep 1, 2021

View reviewed changes

wilburrito approved these changes Sep 1, 2021

View reviewed changes

Merge remote-tracking branch 'origin/add-gradle-support'

b571757

Merge add-gradle-support

JasonC01 reviewed Sep 3, 2021

View reviewed changes

Smanmos suggested changes Sep 5, 2021

View reviewed changes

loose-bus-change added 3 commits September 7, 2021 23:53

Finish Level-10

e13fa9f

Finish A-Assertions

95a3313

Added assertions to the code This ensures that there are no unexpected errors in the code during running It is being fixed by adding relevant asserts statements in methods where applicable

loose-bus-change and others added 12 commits September 11, 2021 12:07

Finish-A-CodeQuality

9a716a9

Merge pull request #1 from loose-bus-change/branch-A-Assertions

c62e3af

Finish A-Assertions

Changes

d397c7e

Fix conflicts

ff9f39c

Merge branch 'master' into branch-A-CodeQuality

dd5f648

Merge pull request #2 from loose-bus-change/branch-A-CodeQuality

ff57ee3

Finish-A-CodeQuality

Fix conflict in text file

9a398f3

Finish BCD-Extensions

10980c9

Add Ui.png

223c05f

Add User guide

1d6ed65

Update ReadMe

e9fb36d

Edit User guide

8f6e846

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Saketh] iP #484

[Saketh] iP #484

loose-bus-change commented Aug 27, 2021 •

edited

Loading

gordonlzy left a comment

gordonlzy Sep 1, 2021

Smanmos Sep 5, 2021

gordonlzy Sep 1, 2021

gordonlzy Sep 1, 2021

wilburrito Sep 1, 2021

Smanmos Sep 5, 2021

gordonlzy Sep 1, 2021

wilburrito left a comment

wilburrito Sep 1, 2021

wilburrito Sep 1, 2021

wilburrito Sep 1, 2021

JasonC01 left a comment

JasonC01 Sep 3, 2021

Smanmos left a comment

Smanmos Sep 5, 2021

Smanmos Sep 5, 2021

Smanmos Sep 5, 2021

Smanmos Sep 5, 2021

Smanmos Sep 5, 2021

[Saketh] iP #484

Are you sure you want to change the base?

[Saketh] iP #484

Conversation

loose-bus-change commented Aug 27, 2021 • edited Loading

Duke

gordonlzy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wilburrito left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JasonC01 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Smanmos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

loose-bus-change commented Aug 27, 2021 •

edited

Loading