[CS2103-W12-1] SportsPA #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
============================================
+ Coverage 72.15% 78.68% +6.53%
- Complexity 399 978 +579
============================================
Files 70 131 +61
Lines 1232 2656 +1424
Branches 125 331 +206
============================================
+ Hits 889 2090 +1201
- Misses 311 465 +154
- Partials 32 101 +69
Continue to review full report at Codecov.
|
Fix format error in DG
Dev Guide: Update implementation details and add diagrams for find member feature
Deleted member is removed from all locations immediately and list is refreshed.
Add AllocateMemberCommand and DeallocateMemberCommand tests. Update EditFacilityCommand tests. Update javadocs and comments.
Update DeleteMemberCommand and EditFacilityCommandTest. add AllocateMemberCommandTest and DeallocateMemberCommandTest.
Fix bugs regarding error messages and increase result window height
Update command to throw CommandException if one or more of the indices provided is invalid.
Resolve merge conflicts and update messages.
Update SetMemberAvailability Command
Update EditMemberCommand such that if a person is edited, they are removed from the allocation maps of all facilities.
Update edit member command
SetMemberAvailabilityCommand and EditMemberCommand removes the members whose details have been changed from all allocations.
ModelStub overrides removePersonFromAllocations method.
…lityCommand Update edit member and set member availability command
Change diagram sizes
# Conflicts: # src/test/java/seedu/address/model/ModelManagerTest.java
Code quality improvements
Fix sizes of diagrams
Fix typo in my PPP
Update PPP
v1.4 Release PR
Fix typo in ppp
Add line separator for DG Effort section
Change java fx to 11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CCAs have many members and it can be hard for the leaders to keep track of everyone’s information and organise sessions, especially with COVID restrictions. The app will help NUS Sports CCA leaders to be able to better manage contact, attendance, administrative information of their members and training sessions.