Skip to content

Commit

Permalink
Do not log node exists/shutdown status at default verbosity (#118)
Browse files Browse the repository at this point in the history
Previously, the controller logged two lines for every node
approximately every 7 seconds, or about 1000 lines per node,
per hour.

Moreover, nearly identical messages are already logged in
a different function, at verbosity level 1.
  • Loading branch information
dlipovetsky authored Jan 8, 2024
1 parent 686c526 commit a88565a
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions pkg/provider/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,8 @@ func (n *nutanixManager) nodeExists(ctx context.Context, node *v1.Node) (bool, e
if !strings.Contains(fmt.Sprint(err), "ENTITY_NOT_FOUND") {
return false, err
}
klog.Infof("Node %s does not exist!", node.Name)
return false, nil
}
klog.Infof("Node %s exists!", node.Name)
return true, nil
}

Expand All @@ -215,10 +213,8 @@ func (n *nutanixManager) isNodeShutdown(ctx context.Context, node *v1.Node) (boo
return false, err
}
if n.isVMShutdown(vm) {
klog.Infof("Node %s is shutdown!", node.Name)
return true, nil
}
klog.Infof("Node %s is not shutdown!", node.Name)
return false, nil
}

Expand Down

0 comments on commit a88565a

Please sign in to comment.