Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the checkout sha for github actions #179

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

thunderboltsid
Copy link
Contributor

github.event.pull_request.merge_commit_sha seems to have some buggy behavior.

`github.event.pull_request.merge_commit_sha` seems to have some buggy
behavior.
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.45%. Comparing base (dd452c0) to head (b30a2c9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   82.45%   82.45%           
=======================================
  Files           8        8           
  Lines         359      359           
=======================================
  Hits          296      296           
  Misses         63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Jul 30, 2024

Failing TrivyScan fixed in #180
Seems like we're in a catch 22. We can't merge one without the other.

@tuxtof tuxtof merged commit 1363d13 into main Jul 30, 2024
6 of 8 checks passed
@tuxtof tuxtof deleted the issue/actions-checkout-sha branch July 30, 2024 15:10
@thunderboltsid thunderboltsid added the ignore-for-release Ignore for release label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Ignore for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants