Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add optional filtered node IP address config #187

Merged
merged 4 commits into from
Aug 25, 2024

Conversation

jimmidyson
Copy link
Member

This can be used to e.g. filter out CP endpoint IPs as used by
kube-vip. Without this there is the potential to assign the
kube-vip IP to the node address, leading to cluster networking
failures, as see when testing with DHCP subnets on Nutanix.

This can be used to e.g. filter out CP endpoint IPs as used by
kube-vip. Without this there is the potential to assign the
kube-vip IP to the node address, leading to cluster networking
failures, as see when testing with DHCP subnets on Nutanix.
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.27%. Comparing base (747d79e) to head (d30ef9e).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/provider/manager.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   82.17%   82.27%   +0.09%     
==========================================
  Files           8        8              
  Lines         359      361       +2     
==========================================
+ Hits          295      297       +2     
  Misses         64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

manifests/cm.yaml Outdated Show resolved Hide resolved
@thunderboltsid thunderboltsid merged commit 5cc04af into main Aug 25, 2024
7 of 8 checks passed
@nutanix-cn-prow-bot nutanix-cn-prow-bot bot deleted the jimmi/filter-cp-ips branch August 25, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants