Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rbac): add read access to services #191

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

fad3t
Copy link
Contributor

@fad3t fad3t commented Oct 25, 2024

What this PR does / why we need it:
Add services RO permission to the system:cloud-controller-manager cluster role.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #190

Release note:

fix(rbac): allow cloud controller manager to read services

@fad3t
Copy link
Contributor Author

fad3t commented Oct 25, 2024

@tuxtof FYI -- I'll do the same PR in the helm repository

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.05%. Comparing base (d8c65d3) to head (10f8c9c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files           8        8           
  Lines         379      379           
=======================================
  Hits          311      311           
  Misses         68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuxtof tuxtof requested a review from thunderboltsid October 25, 2024 10:13
@thunderboltsid thunderboltsid merged commit 0443599 into nutanix-cloud-native:main Dec 16, 2024
8 checks passed
@fad3t fad3t deleted the fix-rbac-svc branch December 16, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing permissions for cloud-controller-manager service account
3 participants