-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add last git commit hash to build flags #332
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
=====================================
Coverage 2.61% 2.61%
=====================================
Files 4 4
Lines 995 995
=====================================
Hits 26 26
Misses 969 969 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/approve |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f40ca54
to
ef8eddf
Compare
/retest |
1 similar comment
/retest |
ef8eddf
to
dc3e7c4
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
pls post the log output of the test showing the commit id for completeness in the description |
dc3e7c4
to
bb53b2f
Compare
This ensures we have the git hash of the changes in our CI logs so we can correlate the code changes being executed.
bb53b2f
to
d28682b
Compare
✅ None of your dependencies violate policy! |
/retest |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adiantum, thunderboltsid, tuxtof The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This ensures we have the git hash of the changes in our CI logs so we can correlate the code changes being executed.
…3.0 (#424) * Fix credentials delete logic (#301) - check if no delete attempt occured - check if no secret present in cluster - add integration test case in e2e suite - change Makefile test-e2e target to make able to run selected tests using GINKGO_FOCUS env variable - code grooming * Bump docker/metadata-action from 4 to 5 (#317) Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 4 to 5. - [Release notes](https://github.com/docker/metadata-action/releases) - [Upgrade guide](https://github.com/docker/metadata-action/blob/master/UPGRADE.md) - [Commits](docker/metadata-action@v4...v5) --- updated-dependencies: - dependency-name: docker/metadata-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/login-action from 2 to 3 (#316) Bumps [docker/login-action](https://github.com/docker/login-action) from 2 to 3. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v2...v3) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump aquasecurity/trivy-action from 0.11.2 to 0.12.0 (#313) Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.11.2 to 0.12.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@0.11.2...0.12.0) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3 to 4 (#314) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(manager): remove CPU limit and increase memory limit (#319) * E2E for Cilium CNI without Kubeproxy (#310) - add manifest scripts - change makefile * Bump aquasecurity/trivy-action from 0.12.0 to 0.13.0 (#324) Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.12.0 to 0.13.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@0.12.0...0.13.0) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump aquasecurity/trivy-action from 0.13.0 to 0.13.1 (#326) Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.13.0 to 0.13.1. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@0.13.0...0.13.1) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump aquasecurity/trivy-action from 0.13.1 to 0.14.0 (#327) Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.13.1 to 0.14.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@0.13.1...0.14.0) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix CVE-2023-39325 (#329) * update kube-vip to v0.6.3 (#320) * Add codecov.yml to ensure adequate patch coverage (#328) This sets the minimum patch coverage required for changes to repo to 75%. * Add last git commit hash to build flags (#332) This ensures we have the git hash of the changes in our CI logs so we can correlate the code changes being executed. * Cleanup for passing the linter (#336) * Delete unused code from pkg/context * Run gofumpt on the code * Add lint fixes to test package * Skip linting the conversion functions The conversion functions are infinitely recursive and cause linting errors. * Remove unnecessary statement in lint target * Revert file-scope licenses * Bump aquasecurity/trivy-action from 0.14.0 to 0.15.0 (#337) Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.14.0 to 0.15.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@0.14.0...0.15.0) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update controller-gen to v0.14.0 Peg go version in build job to go1.21 Update manifests Run `make manifests` --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Ilya Alekseyev <ilya.alekseyev@nutanix.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Frederic M <43849398+fad3t@users.noreply.github.com> Co-authored-by: Christophe Jauffret <christophe.jauffret@nutanix.com>
This ensures we have the git hash of the changes in our CI logs so we can correlate the code changes being executed.
This ensures we have the git hash of the changes in our CI logs so we can correlate the code changes being executed.
How has this been tested?