Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Migrate to devbox for tooling configurations #338

Closed
wants to merge 5 commits into from

Conversation

jimmidyson
Copy link
Member

What this PR does / why we need it:
This PR switches to using devbox to provide configure developer tooling, which in my experience results in a more consistent environment between dev and test machines.

This also updates the release process to use goreleaser.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

How Has This Been Tested?:

I have tested the builds and release process in my own fork and it all worked smoothly, although I haven't been able to launch e2e tests so that could be broken - any help testing those would be appreciated 🙏

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@nutanix-cn-prow-bot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jimmidyson
Copy link
Member Author

/test all

1 similar comment
@jimmidyson
Copy link
Member Author

/test all

@jimmidyson
Copy link
Member Author

/test all

@jimmidyson
Copy link
Member Author

/test all

@nutanix-cn-prow-bot
Copy link

@jimmidyson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ncn-1-calico-k8s-v1.26.1 2637792 link false /test e2e-ncn-1-calico-k8s-v1.26.1

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@dkoshkin dkoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes!

# Automatically sets up your devbox environment whenever you cd into this
# directory via our direnv integration:

eval "$(devbox generate direnv --print-envrc)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops we'll probably want to revert #346 as part of this this PR

.goreleaser.yml Show resolved Hide resolved
</pre>

## Deploy cluster-api-provider-nutanix CRDs on test management cluster
<pre>
make deploy
make dev.run-on-kind
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does devbox have gojq?

make[1]: Leaving directory '/home/dkoshkin/src/github.com/nutanix-cloud-native/cluster-api-provider-nutanix'
bash: line 1: gojq: command not found
ERROR: image: "ko.local/cluster-api-provider-nutanix:" not present locally
make: *** [make/dev.mk:19: dev.run-on-kind] Error 1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Try again, I missed it from the configuration.

</pre>

## Deploy test workload cluster
Note: Update ./clusterctl.yaml with appropriate configuration before running following commands
<pre>
make test-clusterctl-create
make test.clusterctl-create
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing KIND kubeconfig

Error: management cluster not available. Cannot auto-discover target namespace. Please specify a target namespace: invalid kubeconfig file; clusterctl requires a valid kubeconfig file to connect to the management cluster: no configuration has been provided, try setting KUBERNETES_MASTER environment variable

## Prepare local clusterctl
<pre>
make prepare-local-clusterctl
make build-snapshot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we even need the build anymore, the dev.run-on-kind target already runs release-snapshot

@jimmidyson
Copy link
Member Author

Closing in deference to #358.

@jimmidyson jimmidyson closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants