refactor: task status file #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
force-pushed
the
rafactor-task-status
branch
from
771cd7c to
9c533b8
Compare
dkoshkin
commented
Jan 5, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
+ Coverage 11.28% 12.53% +1.24%
==========================================
Files 19 20 +1
Lines 2021 2003 -18
==========================================
+ Hits 228 251 +23
+ Misses 1793 1752 -41 ☔ View full report in Codecov by Sentry. |
dkoshkin
force-pushed
the
rafactor-task-status
branch
from
9c533b8 to
986b2ab
Compare
|
/retest |
dkoshkin
force-pushed
the
rafactor-task-status
branch
from
986b2ab to
004c55a
Compare
adiantum
reviewed
Jan 5, 2024
|
/retest |
|
/ok-to-test |
|
/lgtm |
deepakm-ntnx
reviewed
Jan 5, 2024
dkoshkin
force-pushed
the
rafactor-task-status
branch
from
18525a6 to
ba9b19d
Compare
The ctx passed into WaitForTaskToSucceed is only used to cancel HTTP reqests and not to cancel the wait.
dkoshkin
force-pushed
the
rafactor-task-status
branch
from
ba9b19d to
946d1c2
Compare
thunderboltsid
approved these changes
Jan 10, 2024
|
/approve |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adiantum, dkoshkin, thunderboltsid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thunderboltsid
merged commit 5fd7ada
into
nutanix-cloud-native:main
5 of 7 checks passed
thunderboltsid
pushed a commit
that referenced
this pull request
Apr 24, 2024
* test: add unit tests for pkg/client/state * refactor: use wait.Poll function waiting for task state * refactor: use consistent task status names * fixup! test: add unit tests for pkg/client/state * fix: revert to previous behaviod polling forever The ctx passed into WaitForTaskToSucceed is only used to cancel HTTP reqests and not to cancel the wait. * chore: add license headers * fix: better function name
thunderboltsid
pushed a commit
that referenced
this pull request
Apr 29, 2024
* test: add unit tests for pkg/client/state * refactor: use wait.Poll function waiting for task state * refactor: use consistent task status names * fixup! test: add unit tests for pkg/client/state * fix: revert to previous behaviod polling forever The ctx passed into WaitForTaskToSucceed is only used to cancel HTTP reqests and not to cancel the wait. * chore: add license headers * fix: better function name
thunderboltsid
pushed a commit
that referenced
this pull request
May 2, 2024
* test: add unit tests for pkg/client/state * refactor: use wait.Poll function waiting for task state * refactor: use consistent task status names * fixup! test: add unit tests for pkg/client/state * fix: revert to previous behaviod polling forever The ctx passed into WaitForTaskToSucceed is only used to cancel HTTP reqests and not to cancel the wait. * chore: add license headers * fix: better function name
thunderboltsid
added a commit
that referenced
this pull request
May 2, 2024
* fix: improve error handling for Prism Client (#354) * fix: use wrapper errors to clearly denote issues in client building * fix: adds a function to properly sanitize the address * fix: adds tests for ip address case given * fix: uses a defined type for port error * fix: clean up variable naming * fix: remove validation here to be moved into prism-client * refactor: task status file (#355) * test: add unit tests for pkg/client/state * refactor: use wait.Poll function waiting for task state * refactor: use consistent task status names * fixup! test: add unit tests for pkg/client/state * fix: revert to previous behaviod polling forever The ctx passed into WaitForTaskToSucceed is only used to cancel HTTP reqests and not to cancel the wait. * chore: add license headers * fix: better function name * refactor: client.go file helper methods (#360) * refactor: client.go file helper methods Refactored the existing methods and functions to be unit testable. Also made some methods that do not use the struct as generic functions. The changes were primarily an effort to add unit test coverage. * refactor: more testable read file function * test: new nutanixcluster types unit tests * test: additional test cases for errors * fixup! refactor: client.go file helper methods * fixup! refactor: client.go file helper methods * fixup! refactor: more testable read file function * fixup! refactor: client.go file helper methods * Switch Nutanix Client to using Session Auth (#398) This will ensure we make fewer basic auth requests to Prism Central IAM Services. --------- Co-authored-by: Faiq <faiq.raza@nutanix.com> Co-authored-by: Dimitri Koshkin <dimitri.koshkin@nutanix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This started as an effort to start increasing the code coverage, but noticed that there was some code we can remove and instead rely on the apimachine
waithelper functions.notice how only the error message with the timeout changed, all other tests cases stayed the same, all tests stayed the same after the refactor)Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
How Has This Been Tested?:
New unit tests
Special notes for your reviewer:
I broke up the PR into logical commits and would recommend reviewing it that way too.
I initially started by trying to mock the client but the is a bug that prevented me from doing that nutanix-cloud-native/prism-go-client#150. I went with the http route based on the client's own test files https://github.com/nutanix-cloud-native/prism-go-client/blob/main/v3/v3_service_test.go, but can refactor back to using mocks if we find that to be easier to maintain, if/when the bug PR is merged and released.
Release note: