Cherry-pick PR #382 to release-v1.2 #419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required two changes:
- Remove hostAliases from kube-vip podspec
This is addressed by adding entries directly to the /etc/hosts
- Do a super-admin.conf switcheroo for the kube-vip static pod
Add pre and post kubeadm commands for handling kubernetes
versions v1.29.0+. The prekubeadm command checks if kubeadm
init has been run and if it is, it replaces the kubeconfig
hostPath in kube-vip static pod from admin.conf to the
super-admin.conf. The postkubeadm command checks if
kubeadm init has been run and if it is, it changes the
hostPath in kube-vip static pod from super-admin.conf
back to admin.conf.
thunderboltsid
changed the title
|
/test e2e-k8s-upgrade |
|
@thunderboltsid: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
deepakm-ntnx
approved these changes
Apr 25, 2024
|
closing this PR in favor of #421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-Pick Details