fix(controller): Move v4 client instantiation to reconcileDelete #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
+ Coverage 29.33% 31.14% +1.80%
==========================================
Files 14 14
Lines 1476 1477 +1
==========================================
+ Hits 433 460 +27
+ Misses 1043 1017 -26 ☔ View full report in Codecov by Sentry. |
dkoshkin
reviewed
Jul 30, 2024
thunderboltsid
force-pushed
the
issue/fix-v4client-instantiation
branch
from
dae5e54 to
14c2186
Compare
thunderboltsid
force-pushed
the
issue/fix-v4client-instantiation
branch
from
14c2186 to
618f939
Compare
thunderboltsid
requested review from
deepakm-ntnx
and removed request for
tuxtof and
yannickstruyf3
dkoshkin
approved these changes
Jul 31, 2024
In order to reduce the number of calls made to /prism_central to establish whether a v4 client can be created, we move the v4 client creation to reconcileDelete function as currently that's the only place where we need to make v4 VG detach calls.
thunderboltsid
force-pushed
the
issue/fix-v4client-instantiation
branch
from
618f939 to
452336c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reduce the number of calls made to /prism_central to establish whether a v4 client can be created, we move the v4 client creation to reconcileDelete function as currently that's the only place where we need to make v4 VG detach calls. This ensures we don't impact the regular reconcile cycle and all the new calls only take place on the delete path.