-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass server->client command over a separate socket pair #762
Merged
Commits on Aug 15, 2023
-
Use separate socket for server->client commands
This change adds support for a separate socket to carry commands in the server-to-client direction. It has proven problematic to send commands in both directions over a single socket, since matching replies to commands can become non-trivial when both sides send commands at the same time and adds significant complexity. See issue nutanix#279 for details. To set up the reverse communication channel, the client indicates support for it via a new capability flag in the version message. The server will then create a fresh pair of sockets and pass one end to the client in its version reply. When the server wishes to send commands to the client at a later point, it now uses its end of the new socket pair rather than the main socket. Corresponding replies are also passed back over the new socket pair. Signed-off-by: Mattias Nissler <mnissler@rivosinc.com>
Configuration menu - View commit details
-
Copy full SHA for fe1d614 - Browse repository at this point
Copy the full SHA fe1d614View commit details -
Introduce Client class in python tests
Many tests have a `sock` global holding the client socket. In order to allow additional client context to be managed, introduce a Client class and replace the `sock` global with `client` global object. Signed-off-by: Mattias Nissler <mnissler@rivosinc.com>
Configuration menu - View commit details
-
Copy full SHA for 4025f6e - Browse repository at this point
Copy the full SHA 4025f6eView commit details -
Add pytest for vfu_sgl_{read,write}
The new tests verify behavior of vfu_sgl_{read,write} for success and error cases. Signed-off-by: Mattias Nissler <mnissler@rivosinc.com>
Configuration menu - View commit details
-
Copy full SHA for c01b7fe - Browse repository at this point
Copy the full SHA c01b7feView commit details -
Describe socket separation in protocol specification
Include rationale and operation of separate server-to-client command channel in the protocol description and indicate which commands should be processed on the separate socket. Signed-off-by: Mattias Nissler <mnissler@rivosinc.com>
Configuration menu - View commit details
-
Copy full SHA for 7eb0082 - Browse repository at this point
Copy the full SHA 7eb0082View commit details
Commits on Aug 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ee1de6f - Browse repository at this point
Copy the full SHA ee1de6fView commit details
Commits on Aug 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6cae619 - Browse repository at this point
Copy the full SHA 6cae619View commit details
Commits on Aug 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 864c8cd - Browse repository at this point
Copy the full SHA 864c8cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54b70e1 - Browse repository at this point
Copy the full SHA 54b70e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 654829e - Browse repository at this point
Copy the full SHA 654829eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc2551e - Browse repository at this point
Copy the full SHA cc2551eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f3d8d5 - Browse repository at this point
Copy the full SHA 3f3d8d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce3218e - Browse repository at this point
Copy the full SHA ce3218eView commit details
Commits on Sep 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for beb8d78 - Browse repository at this point
Copy the full SHA beb8d78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d56e0b - Browse repository at this point
Copy the full SHA 4d56e0bView commit details
Commits on Sep 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0860735 - Browse repository at this point
Copy the full SHA 0860735View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.