Skip to content

WIP: add Orchard output generation to fake_compact_block #2599

WIP: add Orchard output generation to fake_compact_block

WIP: add Orchard output generation to fake_compact_block #2599

Triggered via push March 7, 2024 16:56
Status Failure
Total duration 9m 12s
Artifacts

ci.yml

on: push
Matrix: build-latest
Matrix: build-nodefault
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

50 errors and 5 warnings
Rustfmt
Process completed with exit code 1.
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
Latest build on ubuntu-latest
Process completed with exit code 101.
Latest build on windows-latest
The job was canceled because "ubuntu-latest" failed.
Latest build on windows-latest
The operation was canceled.
Latest build on macOS-latest
The job was canceled because "ubuntu-latest" failed.
Latest build on macOS-latest
The operation was canceled.
mismatched types: zcash_client_sqlite/src/testing.rs#L928
error[E0308]: mismatched types --> zcash_client_sqlite/src/testing.rs:928:13 | 927 | let note = Note::from_parts( | ---------------- arguments to this function are incorrect 928 | to, | ^^ expected struct `sapling_crypto::PaymentAddress`, found enum `zcash_client_backend::address::Address` | note: associated function defined here --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/sapling-crypto-0.1.1/src/note.rs:77:12 | 77 | pub fn from_parts(recipient: PaymentAddress, value: NoteValue, rseed: Rseed) -> Self { | ^^^^^^^^^^
arguments to this function are incorrect: zcash_client_sqlite/src/testing.rs#L261
error[E0308]: arguments to this function are incorrect --> zcash_client_sqlite/src/testing.rs:261:18 | 261 | let cb = fake_compact_block_spending( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... 266 | dfvk, | ---- expected struct `zcash_client_backend::keys::UnifiedFullViewingKey`, found struct `sapling_crypto::zip32::DiversifiableFullViewingKey` 267 | to, | -- expected enum `zcash_client_backend::address::Address`, found struct `sapling_crypto::PaymentAddress` | = note: expected reference `&zcash_client_backend::keys::UnifiedFullViewingKey` found reference `&sapling_crypto::zip32::DiversifiableFullViewingKey` note: function defined here --> zcash_client_sqlite/src/testing.rs:903:15 | 903 | pub(crate) fn fake_compact_block_spending<P: consensus::Parameters>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ 904 | params: &P, | ---------- 905 | height: BlockHeight, | ------------------- 906 | prev_hash: BlockHash, | -------------------- 907 | (nf, in_value): (Nullifier, NonNegativeAmount), | ---------------------------------------------- 908 | ufvk: &UnifiedFullViewingKey, | ---------------------------- 909 | to: Address, | ----------- 910 | value: NonNegativeAmount, | ------------------------ 911 | initial_sapling_tree_size: u32, | ------------------------------ help: try wrapping the expression in `zcash_client_backend::address::Address::Sapling` | 267 | zcash_client_backend::address::Address::Sapling(to), | ++++++++++++++++++++++++++++++++++++++++++++++++ +
this function takes 8 arguments but 7 arguments were supplied: zcash_client_sqlite/src/testing.rs#L226
error[E0061]: this function takes 8 arguments but 7 arguments were supplied --> zcash_client_sqlite/src/testing.rs:226:24 | 226 | let (cb, nf) = fake_compact_block( | ________________________^^^^^^^^^^^^^^^^^^- 227 | | &self.network(), 228 | | height, 229 | | prev_hash, ... | 233 | | initial_sapling_tree_size, 234 | | ); | |_________- an argument of type `u32` is missing | note: function defined here --> zcash_client_sqlite/src/testing.rs:788:15 | 788 | pub(crate) fn fake_compact_block<P: consensus::Parameters>( | ^^^^^^^^^^^^^^^^^^ 789 | params: &P, | ---------- 790 | height: BlockHeight, | ------------------- 791 | prev_hash: BlockHash, | -------------------- 792 | ufvk: &UnifiedFullViewingKey, | ---------------------------- 793 | note_recipient: AddressRequest, | ------------------------------ 794 | note_value: NonNegativeAmount, | ----------------------------- 795 | initial_sapling_tree_size: u32, | ------------------------------ 796 | initial_orchard_tree_size: u32, | ------------------------------ help: provide the argument | 226 | let (cb, nf) = fake_compact_block(&self.network(), height, prev_hash, dfvk, req, value, initial_sapling_tree_size, /* u32 */); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arguments to this function are incorrect: zcash_client_sqlite/src/testing.rs#L200
error[E0308]: arguments to this function are incorrect --> zcash_client_sqlite/src/testing.rs:200:30 | 200 | let (res, nf) = self.generate_block_at( | ^^^^^^^^^^^^^^^^^ ... 203 | dfvk, | ---- expected struct `zcash_client_backend::keys::UnifiedFullViewingKey`, found struct `sapling_crypto::zip32::DiversifiableFullViewingKey` 204 | req, | --- expected struct `testing::AddressRequest`, found enum `testing::AddressType` | = note: expected reference `&zcash_client_backend::keys::UnifiedFullViewingKey` found reference `&sapling_crypto::zip32::DiversifiableFullViewingKey` note: associated function defined here --> zcash_client_sqlite/src/testing.rs:217:19 | 217 | pub(crate) fn generate_block_at( | ^^^^^^^^^^^^^^^^^ 218 | &mut self, 219 | height: BlockHeight, | ------------------- 220 | prev_hash: BlockHash, | -------------------- 221 | dfvk: &UnifiedFullViewingKey, | ---------------------------- 222 | req: AddressRequest, | ------------------- 223 | value: NonNegativeAmount, | ------------------------ 224 | initial_sapling_tree_size: u32, | ------------------------------
arguments to this function are incorrect: zcash_client_sqlite/src/wallet.rs#L2419
error[E0308]: arguments to this function are incorrect --> zcash_client_sqlite/src/wallet.rs:2419:20 | 2419 | let _ = st.generate_block_at( | ^^^^^^^^^^^^^^^^^ ... 2422 | &not_our_key, | ------------ expected struct `zcash_client_backend::keys::UnifiedFullViewingKey`, found struct `sapling_crypto::zip32::DiversifiableFullViewingKey` 2423 | AddressType::DefaultExternal, | ---------------------------- expected struct `testing::AddressRequest`, found enum `testing::AddressType` | = note: expected reference `&zcash_client_backend::keys::UnifiedFullViewingKey` found reference `&sapling_crypto::zip32::DiversifiableFullViewingKey` note: associated function defined here --> zcash_client_sqlite/src/testing.rs:217:19 | 217 | pub(crate) fn generate_block_at( | ^^^^^^^^^^^^^^^^^ 218 | &mut self, 219 | height: BlockHeight, | ------------------- 220 | prev_hash: BlockHash, | -------------------- 221 | dfvk: &UnifiedFullViewingKey, | ---------------------------- 222 | req: AddressRequest, | ------------------- 223 | value: NonNegativeAmount, | ------------------------ 224 | initial_sapling_tree_size: u32, | ------------------------------
arguments to this function are incorrect: zcash_client_sqlite/src/wallet.rs#L2403
error[E0308]: arguments to this function are incorrect --> zcash_client_sqlite/src/wallet.rs:2403:20 | 2403 | let _ = st.generate_block_at( | ^^^^^^^^^^^^^^^^^ ... 2406 | &not_our_key, | ------------ expected struct `zcash_client_backend::keys::UnifiedFullViewingKey`, found struct `sapling_crypto::zip32::DiversifiableFullViewingKey` 2407 | AddressType::DefaultExternal, | ---------------------------- expected struct `testing::AddressRequest`, found enum `testing::AddressType` | = note: expected reference `&zcash_client_backend::keys::UnifiedFullViewingKey` found reference `&sapling_crypto::zip32::DiversifiableFullViewingKey` note: associated function defined here --> zcash_client_sqlite/src/testing.rs:217:19 | 217 | pub(crate) fn generate_block_at( | ^^^^^^^^^^^^^^^^^ 218 | &mut self, 219 | height: BlockHeight, | ------------------- 220 | prev_hash: BlockHash, | -------------------- 221 | dfvk: &UnifiedFullViewingKey, | ---------------------------- 222 | req: AddressRequest, | ------------------- 223 | value: NonNegativeAmount, | ------------------------ 224 | initial_sapling_tree_size: u32, | ------------------------------
arguments to this function are incorrect: zcash_client_sqlite/src/wallet/scanning.rs#L968
error[E0308]: arguments to this function are incorrect --> zcash_client_sqlite/src/wallet/scanning.rs:968:12 | 968 | st.generate_block_at( | ^^^^^^^^^^^^^^^^^ ... 971 | &dfvk, | ----- expected struct `zcash_client_backend::keys::UnifiedFullViewingKey`, found struct `sapling_crypto::zip32::DiversifiableFullViewingKey` 972 | AddressType::DefaultExternal, | ---------------------------- expected struct `testing::AddressRequest`, found enum `testing::AddressType` | = note: expected reference `&zcash_client_backend::keys::UnifiedFullViewingKey` found reference `&sapling_crypto::zip32::DiversifiableFullViewingKey` note: associated function defined here --> zcash_client_sqlite/src/testing.rs:217:19 | 217 | pub(crate) fn generate_block_at( | ^^^^^^^^^^^^^^^^^ 218 | &mut self, 219 | height: BlockHeight, | ------------------- 220 | prev_hash: BlockHash, | -------------------- 221 | dfvk: &UnifiedFullViewingKey, | ---------------------------- 222 | req: AddressRequest, | ------------------- 223 | value: NonNegativeAmount, | ------------------------ 224 | initial_sapling_tree_size: u32, | ------------------------------
arguments to this function are incorrect: zcash_client_sqlite/src/wallet/scanning.rs#L852
error[E0308]: arguments to this function are incorrect --> zcash_client_sqlite/src/wallet/scanning.rs:852:12 | 852 | st.generate_block_at( | ^^^^^^^^^^^^^^^^^ ... 855 | &dfvk, | ----- expected struct `zcash_client_backend::keys::UnifiedFullViewingKey`, found struct `sapling_crypto::zip32::DiversifiableFullViewingKey` 856 | AddressType::DefaultExternal, | ---------------------------- expected struct `testing::AddressRequest`, found enum `testing::AddressType` | = note: expected reference `&zcash_client_backend::keys::UnifiedFullViewingKey` found reference `&sapling_crypto::zip32::DiversifiableFullViewingKey` note: associated function defined here --> zcash_client_sqlite/src/testing.rs:217:19 | 217 | pub(crate) fn generate_block_at( | ^^^^^^^^^^^^^^^^^ 218 | &mut self, 219 | height: BlockHeight, | ------------------- 220 | prev_hash: BlockHash, | -------------------- 221 | dfvk: &UnifiedFullViewingKey, | ---------------------------- 222 | req: AddressRequest, | ------------------- 223 | value: NonNegativeAmount, | ------------------------ 224 | initial_sapling_tree_size: u32, | ------------------------------
arguments to this function are incorrect: zcash_client_sqlite/src/wallet/scanning.rs#L567
error[E0308]: arguments to this function are incorrect --> zcash_client_sqlite/src/wallet/scanning.rs:567:12 | 567 | st.generate_block_at( | ^^^^^^^^^^^^^^^^^ ... 570 | &dfvk, | ----- expected struct `zcash_client_backend::keys::UnifiedFullViewingKey`, found struct `sapling_crypto::zip32::DiversifiableFullViewingKey` 571 | AddressType::DefaultExternal, | ---------------------------- expected struct `testing::AddressRequest`, found enum `testing::AddressType` | = note: expected reference `&zcash_client_backend::keys::UnifiedFullViewingKey` found reference `&sapling_crypto::zip32::DiversifiableFullViewingKey` note: associated function defined here --> zcash_client_sqlite/src/testing.rs:217:19 | 217 | pub(crate) fn generate_block_at( | ^^^^^^^^^^^^^^^^^ 218 | &mut self, 219 | height: BlockHeight, | ------------------- 220 | prev_hash: BlockHash, | -------------------- 221 | dfvk: &UnifiedFullViewingKey, | ---------------------------- 222 | req: AddressRequest, | ------------------- 223 | value: NonNegativeAmount, | ------------------------ 224 | initial_sapling_tree_size: u32, | ------------------------------
arguments to this function are incorrect: zcash_client_sqlite/src/wallet/sapling.rs#L1805
error[E0308]: arguments to this function are incorrect --> zcash_client_sqlite/src/wallet/sapling.rs:1805:12 | 1805 | st.generate_block_at( | ^^^^^^^^^^^^^^^^^ ... 1808 | &not_our_key, | ------------ expected struct `zcash_client_backend::keys::UnifiedFullViewingKey`, found struct `sapling_crypto::zip32::DiversifiableFullViewingKey` 1809 | AddressType::DefaultExternal, | ---------------------------- expected struct `testing::AddressRequest`, found enum `testing::AddressType` | = note: expected reference `&zcash_client_backend::keys::UnifiedFullViewingKey` found reference `&sapling_crypto::zip32::DiversifiableFullViewingKey` note: associated function defined here --> zcash_client_sqlite/src/testing.rs:217:19 | 217 | pub(crate) fn generate_block_at( | ^^^^^^^^^^^^^^^^^ 218 | &mut self, 219 | height: BlockHeight, | ------------------- 220 | prev_hash: BlockHash, | -------------------- 221 | dfvk: &UnifiedFullViewingKey, | ---------------------------- 222 | req: AddressRequest, | ------------------- 223 | value: NonNegativeAmount, | ------------------------ 224 | initial_sapling_tree_size: u32, | ------------------------------
arguments to this function are incorrect: zcash_client_sqlite/src/wallet/sapling.rs#L1725
error[E0308]: arguments to this function are incorrect --> zcash_client_sqlite/src/wallet/sapling.rs:1725:12 | 1725 | st.generate_block_at( | ^^^^^^^^^^^^^^^^^ ... 1728 | &not_our_key, | ------------ expected struct `zcash_client_backend::keys::UnifiedFullViewingKey`, found struct `sapling_crypto::zip32::DiversifiableFullViewingKey` 1729 | AddressType::DefaultExternal, | ---------------------------- expected struct `testing::AddressRequest`, found enum `testing::AddressType` | = note: expected reference `&zcash_client_backend::keys::UnifiedFullViewingKey` found reference `&sapling_crypto::zip32::DiversifiableFullViewingKey` note: associated function defined here --> zcash_client_sqlite/src/testing.rs:217:19 | 217 | pub(crate) fn generate_block_at( | ^^^^^^^^^^^^^^^^^ 218 | &mut self, 219 | height: BlockHeight, | ------------------- 220 | prev_hash: BlockHash, | -------------------- 221 | dfvk: &UnifiedFullViewingKey, | ---------------------------- 222 | req: AddressRequest, | ------------------- 223 | value: NonNegativeAmount, | ------------------------ 224 | initial_sapling_tree_size: u32, | ------------------------------
arguments to this function are incorrect: zcash_client_sqlite/src/chain.rs#L411
error[E0308]: arguments to this function are incorrect --> zcash_client_sqlite/src/chain.rs:411:12 | 411 | st.generate_block_at( | ^^^^^^^^^^^^^^^^^ ... 414 | &dfvk, | ----- expected struct `zcash_client_backend::keys::UnifiedFullViewingKey`, found struct `sapling_crypto::zip32::DiversifiableFullViewingKey` 415 | AddressType::DefaultExternal, | ---------------------------- expected struct `testing::AddressRequest`, found enum `testing::AddressType` | = note: expected reference `&zcash_client_backend::keys::UnifiedFullViewingKey` found reference `&sapling_crypto::zip32::DiversifiableFullViewingKey` note: associated function defined here --> zcash_client_sqlite/src/testing.rs:217:19 | 217 | pub(crate) fn generate_block_at( | ^^^^^^^^^^^^^^^^^ 218 | &mut self, 219 | height: BlockHeight, | ------------------- 220 | prev_hash: BlockHash, | -------------------- 221 | dfvk: &UnifiedFullViewingKey, | ---------------------------- 222 | req: AddressRequest, | ------------------- 223 | value: NonNegativeAmount, | ------------------------ 224 | initial_sapling_tree_size: u32, | ------------------------------
unused import: `zcash_client_backend::keys::UnifiedAddressRequest`: zcash_client_sqlite/src/testing.rs#L25
error: unused import: `zcash_client_backend::keys::UnifiedAddressRequest` --> zcash_client_sqlite/src/testing.rs:25:5 | 25 | use zcash_client_backend::keys::UnifiedAddressRequest; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `nonempty`: zcash_client_sqlite/src/testing.rs#L8
error: unused import: `nonempty` --> zcash_client_sqlite/src/testing.rs:8:26 | 8 | use nonempty::{NonEmpty, nonempty}; | ^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings`
cannot find value `dfvk` in this scope: zcash_client_sqlite/src/testing.rs#L959
error[E0425]: cannot find value `dfvk` in this scope --> zcash_client_sqlite/src/testing.rs:959:18 | 959 | Some(dfvk.fvk().ovk), | ^^^^ help: a local variable with a similar name exists: `ufvk`
cannot find value `dfvk` in this scope: zcash_client_sqlite/src/testing.rs#L951
error[E0425]: cannot find value `dfvk` in this scope --> zcash_client_sqlite/src/testing.rs:951:27 | 951 | let change_addr = dfvk.default_address().1; | ^^^^ help: a local variable with a similar name exists: `ufvk`
cannot find value `dfvk` in this scope: zcash_client_sqlite/src/testing.rs#L933
error[E0425]: cannot find value `dfvk` in this scope --> zcash_client_sqlite/src/testing.rs:933:18 | 933 | Some(dfvk.fvk().ovk), | ^^^^ help: a local variable with a similar name exists: `ufvk`
cannot find value `dfvk` in this scope: zcash_client_sqlite/src/testing.rs#L856
error[E0425]: cannot find value `dfvk` in this scope --> zcash_client_sqlite/src/testing.rs:856:19 | 856 | (cb, note.nf(&dfvk.fvk().vk.nk, 0)) | ^^^^ help: a local variable with a similar name exists: `ufvk`
cannot find value `note` in this scope: zcash_client_sqlite/src/testing.rs#L856
error[E0425]: cannot find value `note` in this scope --> zcash_client_sqlite/src/testing.rs:856:10 | 856 | (cb, note.nf(&dfvk.fvk().vk.nk, 0)) | ^^^^ not found in this scope
cannot find value `value` in this scope: zcash_client_sqlite/src/testing.rs#L815
error[E0425]: cannot find value `value` in this scope --> zcash_client_sqlite/src/testing.rs:815:65 | 815 | let note = Note::from_parts(to, NoteValue::from_raw(value.into_u64()), rseed); | ^^^^^ not found in this scope
cannot find type `Either` in this scope: zcash_client_sqlite/src/testing.rs#L797
error[E0412]: cannot find type `Either` in this scope --> zcash_client_sqlite/src/testing.rs:797:21 | 797 | ) -> (CompactBlock, Either<sapling::Nullifier, orchard::note::Nullifier>) { | ^^^^^^ not found in this scope | help: consider importing this enum | 1 | use maybe_rayon::iter::Either; |
failed to resolve: use of undeclared crate or module `orchard`: zcash_client_sqlite/src/testing.rs#L797
error[E0433]: failed to resolve: use of undeclared crate or module `orchard` --> zcash_client_sqlite/src/testing.rs:797:48 | 797 | ) -> (CompactBlock, Either<sapling::Nullifier, orchard::note::Nullifier>) { | ^^^^^^^ use of undeclared crate or module `orchard`
Clippy (MSRV)
Clippy had exited with the 101 exit code
Test on ubuntu-latest with --features zfuture
Process completed with exit code 101.
Test on windows-latest with --features unstable-nu6
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on windows-latest with --features unstable-nu6
The operation was canceled.
Test on windows-latest
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on windows-latest
The operation was canceled.
Test on windows-latest with --features orchard
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on windows-latest with --features orchard
The operation was canceled.
Test on windows-latest with --features zfuture
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on windows-latest with --features zfuture
The operation was canceled.
Test on ubuntu-latest
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on ubuntu-latest
The operation was canceled.
Test on ubuntu-latest with --features unstable-nu6
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on ubuntu-latest with --features unstable-nu6
The operation was canceled.
Test on ubuntu-latest with --features orchard
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on ubuntu-latest with --features orchard
The operation was canceled.
Test on macOS-latest
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on macOS-latest
The operation was canceled.
Test on macOS-latest with --features orchard
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on macOS-latest with --features orchard
The operation was canceled.
Code coverage
Process completed with exit code 1.
Clippy (beta)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
protobuf consistency
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: supplypike/setup-bin@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (MSRV)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (MSRV)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/