Skip to content

zcash_client_backend: Generalize DecryptedOutput to support Orchard #2610

zcash_client_backend: Generalize DecryptedOutput to support Orchard

zcash_client_backend: Generalize DecryptedOutput to support Orchard #2610

Triggered via push March 8, 2024 01:26
Status Failure
Total duration 9m 26s
Artifacts

ci.yml

on: push
Matrix: build-latest
Matrix: build-nodefault
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

33 errors and 5 warnings
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
Latest build on ubuntu-latest
Process completed with exit code 101.
Latest build on windows-latest
The job was canceled because "ubuntu-latest" failed.
Latest build on windows-latest
The operation was canceled.
Latest build on macOS-latest
The job was canceled because "ubuntu-latest" failed.
Latest build on macOS-latest
The operation was canceled.
using `clone` on type `A` which implements the `Copy` trait: zcash_client_backend/src/decrypt.rs#L145
error: using `clone` on type `A` which implements the `Copy` trait --> zcash_client_backend/src/decrypt.rs:145:37 | 145 | ... account.clone(), | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `account` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `A` which implements the `Copy` trait: zcash_client_backend/src/decrypt.rs#L111
error: using `clone` on type `A` which implements the `Copy` trait --> zcash_client_backend/src/decrypt.rs:111:34 | 111 | .map(|dfvk| (account.clone(), dfvk)) | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*account` | = note: `-D clippy::clone-on-copy` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
useless conversion to the same type: `zcash_protocol::value::Zatoshis`: zcash_client_backend/src/data_api/wallet/input_selection.rs#L465
error: useless conversion to the same type: `zcash_protocol::value::Zatoshis` --> zcash_client_backend/src/data_api/wallet/input_selection.rs:465:21 | 465 | amount_required.into(), | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `amount_required` | = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
using `clone` on type `A` which implements the `Copy` trait: zcash_client_backend/src/decrypt.rs#L145
error: using `clone` on type `A` which implements the `Copy` trait --> zcash_client_backend/src/decrypt.rs:145:37 | 145 | ... account.clone(), | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `account` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `A` which implements the `Copy` trait: zcash_client_backend/src/decrypt.rs#L111
error: using `clone` on type `A` which implements the `Copy` trait --> zcash_client_backend/src/decrypt.rs:111:34 | 111 | .map(|dfvk| (account.clone(), dfvk)) | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*account` | = note: `-D clippy::clone-on-copy` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
useless conversion to the same type: `zcash_protocol::value::Zatoshis`: zcash_client_backend/src/data_api/wallet/input_selection.rs#L465
error: useless conversion to the same type: `zcash_protocol::value::Zatoshis` --> zcash_client_backend/src/data_api/wallet/input_selection.rs:465:21 | 465 | amount_required.into(), | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `amount_required` | = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Clippy (MSRV)
Clippy had exited with the 101 exit code
Test on ubuntu-latest with --features zfuture
Process completed with exit code 101.
Test on windows-latest with --features unstable-nu6
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on windows-latest with --features unstable-nu6
The operation was canceled.
Test on windows-latest
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on windows-latest
The operation was canceled.
Test on windows-latest with --features orchard
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on windows-latest with --features orchard
The operation was canceled.
Test on windows-latest with --features zfuture
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on windows-latest with --features zfuture
The operation was canceled.
Test on ubuntu-latest
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on ubuntu-latest
The operation was canceled.
Test on ubuntu-latest with --features unstable-nu6
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on ubuntu-latest with --features unstable-nu6
The operation was canceled.
Test on ubuntu-latest with --features orchard
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on ubuntu-latest with --features orchard
The operation was canceled.
Test on macOS-latest with --features orchard
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on macOS-latest with --features orchard
The operation was canceled.
Test on macOS-latest
The job was canceled because "ubuntu-latest_zfuture" failed.
Test on macOS-latest
The operation was canceled.
Code coverage
Process completed with exit code 1.
Clippy (beta)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
protobuf consistency
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: supplypike/setup-bin@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (MSRV)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (MSRV)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/