WIP - Add wildcard to inject directive

[andershagbard]

• Added or updated tests
• Documented user facing changes
• Updated CHANGELOG.md

Resolves #1206

I need some help finishing this. It throws a weird error, probably due to how I made the test. If you run dd($this->toArray) on line 73 in ArgumentSet, you can see it injects the context with the correct value.

Changes

You can now use wildcard in the inject directive.

Breaking changes

None I think?

[andershagbard]

Not sure if we should throw an error with it's not an array here?

[spawnia]

I think so, yeah. * makes no sense otherwise - it is not a valid identifier for a field.

[andershagbard]

I've updated it now. Not sure if i used the correct exception.

[spawnia]

Use DefinitionException, in this case the error must be solved by the developer.

[spawnia]

I think so, yeah. * makes no sense otherwise - it is not a valid identifier for a field.

[spawnia]

Suggested change

	type Mutation {
	updateUser(input: UpdateUser!): Task
	@update
	@inject(context: "user.id", name: "input.tasks.create.*.user_id")
	}
	type Mutation {
	updateUser(input: UpdateUserInput!): Task
	@update
	@inject(context: "user.id", name: "input.tasks.create.*.user_id")
	}
	input UpdateUserInput {
	id: ID!
	tasks: UpdateTasksHasManyInput
	}
	input UpdateTasksHasManyInput {
	create: [CreateTaskInput!]
	}
	input CreateTaskInput {
	title: String!
	}

Makes me wonder if we should make the injection optional. In this example, I could see input.tasks.create being optional, perhaps with input.tasks.update being another possible argument that should also be injected into if present.

[andershagbard]

I guess the same "issue" could exists with just dot notation. But it would make sense to discard it if an array does not exists at the asterisk segment.

[spawnia]

With just dot notation, we force the value at the defined position - and create intermediary inputs if necessary. I guess this could not be desired in every case, but it is how it currently works. At least it is well defined.

In the case of an array, we have the problem that it is less clear what to insert. What number of arguments at the desired position should be added? 1 or another number? I would argue it should always be 0 - that being equivalent to injecting nothing at all.

[andershagbard]

I've taken a slightly different approach, just to make it easy. I've implemented ArrayAccess and let data_set handle the logic.

I've also removed all empty arrays from the values. It caused a array to string conversion error later in the code. In this test: testWillRejectValuesNotPlacedAtArrayWithWildcardInjection

TODO

• Add Iterator to Argument (https://www.php.net/manual/en/class.iterator.php)
• Determinate if Iterator should be added to ArgumentSet aswell

[andershagbard]

Not sure how to solve the unit tests.

[spawnia]

Have you considered adding to ArgumentSetTest? It should be pretty straightforward to test the many possible edge cases there and examine exactly what the result will be.

[spawnia]

I do not get why you keep aliasing $this - why not just it directly?

[spawnia]

Suggested change

	$value = $this->value;
	return new \ArrayIterator($value);
	return new \ArrayIterator($this->value);