This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
match upstream typstfmt config file name #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's fine as long as we warn a bit in the release |
|
I approve the changes btw |
Sounds good. Thanks for taking a look! |
|
LGTM. and we can make improvement about warning in a separated PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typstfmt binary uses
typstfmt.tomlor.typstfmt.tomlinstead oftypstfmt-config.toml(see the source code here). This pull request makes it so we use the same names.One question: would we want to also continue supporting
typstfmt-config.tomlfor backwards compatibility? Or is it fine that we don't since formatting is experimental?