Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (#295799): Add support for ARM64 #32

Merged
merged 1 commit into from
May 27, 2024

Conversation

rfabre
Copy link
Contributor

@rfabre rfabre commented May 23, 2024

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

What is the current behavior?

Chinook snippets can't be installed on ARM64 versions of Visual Studio

What is the new behavior?

Chinook snippets can be installed on ARM64 versions of Visual Studio

Impact on version

  • Major (Public API was modified.)
    • Snippets were removed or renamed.
  • Minor (Public API was extended.)
    • Snippets were added.
  • Patch (Public API was unchanged.)
    • A bug in behavior was fixed.
    • Documentation was changed.
  • None (Snippets were unchanged.)
    • Only code under the build folder was changed.
    • Only code under the .github folder was changed.

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Updated BREAKING_CHANGES.md (if you introduced a breaking change).
  • Your conventional commits are aligned with the Impact on version section.

@rfabre rfabre force-pushed the dev/rofa/add-arm64-support-and-update-readme branch from bc56e4d to 8150bc4 Compare May 23, 2024 18:43
@rfabre rfabre marked this pull request as ready for review May 23, 2024 18:44
@rfabre rfabre requested a review from a team May 24, 2024 18:26
@rfabre rfabre merged commit a367508 into main May 27, 2024
2 checks passed
@rfabre rfabre deleted the dev/rofa/add-arm64-support-and-update-readme branch May 27, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants