Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI Artifact Names, Android and Firebase Conf. Injection #35

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

Soap-141
Copy link
Contributor

@Soap-141 Soap-141 commented Jun 4, 2024

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

  • Fixes an issue with the artifacts.
  • Fixes an issue with Android CI/CD.
  • Adds CI/CD Firebase Configuration injection.

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and src/cli/CLI.md if you made changes to templating.
    • Update AzurePipelines.md and src/app/README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@Marc-Antoine-Soucy Marc-Antoine-Soucy force-pushed the dev/thla/fix-ci branch 2 times, most recently from 16e261e to 4ad8527 Compare June 5, 2024 15:43
@Soap-141 Soap-141 force-pushed the dev/thla/fix-ci branch 2 times, most recently from 06cf16e to 3f97977 Compare June 18, 2024 19:18
@Soap-141 Soap-141 marked this pull request as ready for review June 18, 2024 19:18
@Soap-141
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@Soap-141 Soap-141 force-pushed the dev/thla/fix-ci branch 3 times, most recently from 3c275a7 to 196940b Compare June 18, 2024 20:58
@Soap-141 Soap-141 changed the title fix: CI Artifact Names and Android fix: CI Artifact Names, Android and Firebase Conf. Injection Jun 18, 2024
build/azure-pipelines.yml Show resolved Hide resolved
build/azure-pipelines.yml Show resolved Hide resolved
@Soap-141 Soap-141 merged commit 567eae8 into main Jun 19, 2024
14 checks passed
@Soap-141 Soap-141 deleted the dev/thla/fix-ci branch June 19, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants