Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: integrate bugsee in flutter template and update build pipeline #48

Merged
merged 9 commits into from
Nov 19, 2024

Conversation

koukibadr
Copy link
Contributor

@koukibadr koukibadr commented Nov 13, 2024

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

  • Integrate the Bugsee SDK in the Template App project
  • Implement Bugsee configuration layout in the Diagnostic module as a new Tab called "Bugsee"
  • Integrate manual methods to invoke logging exceptions (logExceptions, showReport)
  • Add enable/disable Bugsee report and persisting the user's config in shared prefs.
  • Add enable/disable video capturing
  • Update the app pipeline to inject the Bugsee token when building the release version

Different Bugsee configuration states in imags:

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and src/cli/CLI.md if you made changes to templating.
    • Update AzurePipelines.md and src/app/README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@koukibadr koukibadr marked this pull request as draft November 13, 2024 11:49
@koukibadr koukibadr force-pushed the config/bk/integrate-bugsee branch from 2dcce05 to 1ff2ee5 Compare November 13, 2024 11:52
@koukibadr koukibadr marked this pull request as ready for review November 14, 2024 11:39
@koukibadr koukibadr self-assigned this Nov 14, 2024
@koukibadr koukibadr marked this pull request as draft November 14, 2024 14:47
.DS_Store Outdated Show resolved Hide resolved
.vscode/launch.json Outdated Show resolved Hide resolved
build/azure-pipelines.yml Outdated Show resolved Hide resolved
build/steps-build-android.yml Outdated Show resolved Hide resolved
@jeanplevesque jeanplevesque requested a review from a team November 14, 2024 15:53
@jeanplevesque
Copy link
Member

You currently have 2 commits, each with the build: conventional commit prefix, however you introduce a new feature and are not only changing code related to the build pipeline so you should at least have a feat: commit.

@jeanplevesque
Copy link
Member

The description section of the Pull Request template must be filled.

@koukibadr koukibadr force-pushed the config/bk/integrate-bugsee branch from c6ad5ba to 3bdbbff Compare November 14, 2024 16:58
@koukibadr koukibadr marked this pull request as ready for review November 14, 2024 16:59
src/app/android/settings.gradle Outdated Show resolved Hide resolved
src/app/lib/access/bugsee/bugsee_repository.dart Outdated Show resolved Hide resolved
src/app/lib/business/bugsee/bugsee_manager.dart Outdated Show resolved Hide resolved
src/app/lib/business/bugsee/bugsee_manager.dart Outdated Show resolved Hide resolved
src/app/lib/business/bugsee/bugsee_manager.dart Outdated Show resolved Hide resolved
src/app/lib/business/bugsee/bugsee_manager.dart Outdated Show resolved Hide resolved
src/app/lib/business/bugsee/bugsee_manager.dart Outdated Show resolved Hide resolved
@koukibadr koukibadr force-pushed the config/bk/integrate-bugsee branch from 98757c3 to a2a88db Compare November 15, 2024 10:37
src/app/lib/business/bugsee/bugsee_manager.dart Outdated Show resolved Hide resolved
src/app/lib/business/bugsee/bugsee_manager.dart Outdated Show resolved Hide resolved
src/app/lib/business/bugsee/bugsee_manager.dart Outdated Show resolved Hide resolved
src/app/lib/business/bugsee/bugsee_manager.dart Outdated Show resolved Hide resolved
@koukibadr koukibadr force-pushed the config/bk/integrate-bugsee branch from a9d47ef to 7e3e5f1 Compare November 18, 2024 11:07
src/app/lib/business/bugsee/bugsee_manager.dart Outdated Show resolved Hide resolved
src/app/lib/business/bugsee/bugsee_manager.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@Soap-141 Soap-141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

src/app/lib/business/bugsee/bugsee_manager.dart Outdated Show resolved Hide resolved
src/app/lib/business/bugsee/bugsee_manager.dart Outdated Show resolved Hide resolved
@koukibadr koukibadr removed the request for review from Marc-Antoine-Soucy November 18, 2024 15:07
@jeanplevesque
Copy link
Member

/azp run

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@koukibadr koukibadr force-pushed the config/bk/integrate-bugsee branch from f6cbfef to 3e1ff16 Compare November 19, 2024 14:25
@koukibadr koukibadr merged commit 39fd7ab into main Nov 19, 2024
16 checks passed
@koukibadr koukibadr deleted the config/bk/integrate-bugsee branch November 19, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants