generated from nventive/Template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Implement conventional commit validation #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanplevesque
requested changes
Nov 28, 2024
jeanplevesque
approved these changes
Nov 28, 2024
mahdichtioui
force-pushed
the
dev/mach/implement-commit-validation
branch
from
November 29, 2024 12:43
7d8e89e
to
0f198b7
Compare
jeanplevesque
requested changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should have 1 commit, not 17.
jeanplevesque
requested changes
Nov 29, 2024
I have changed this PR to draft for now. I'm having a problem validating the PR commit in the pipeline. I'll clean it afterwards |
jeanplevesque
requested changes
Nov 29, 2024
mahdichtioui
force-pushed
the
dev/mach/implement-commit-validation
branch
from
November 29, 2024 15:04
5bd0068
to
9b47ac1
Compare
mahdichtioui
force-pushed
the
dev/mach/implement-commit-validation
branch
from
November 29, 2024 20:23
5d1a69b
to
a1731e1
Compare
jeanplevesque
requested changes
Dec 2, 2024
mahdichtioui
force-pushed
the
dev/mach/implement-commit-validation
branch
from
December 2, 2024 14:33
a1731e1
to
0a80033
Compare
mahdichtioui
force-pushed
the
dev/mach/implement-commit-validation
branch
6 times, most recently
from
December 4, 2024 12:56
316e4e7
to
d7c6c8c
Compare
jeanplevesque
requested changes
Dec 4, 2024
mahdichtioui
force-pushed
the
dev/mach/implement-commit-validation
branch
from
December 4, 2024 16:22
d7c6c8c
to
094d835
Compare
jeanplevesque
approved these changes
Dec 4, 2024
Soap-141
approved these changes
Dec 4, 2024
Marc-Antoine-Soucy
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
Proposed Changes
Description
Impact on version
PR Checklist
Always applicable
No matter your changes, these checks always apply.
README.md
andsrc/cli/CLI.md
if you made changes to templating.AzurePipelines.md
andsrc/app/README.md
if you made changes to pipelines.Diagnostics.md
if you made changes to diagnostic tools.Architecture.md
and its diagrams if you made architecture decisions or if you introduced new recipes.doc/
folder.Contextual
Based on your changes these checks may not apply.
Other information
Internal Issue (If applicable):