Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Implement conventional commit validation #52

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

mahdichtioui
Copy link
Contributor

@mahdichtioui mahdichtioui commented Nov 28, 2024

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and src/cli/CLI.md if you made changes to templating.
    • Update AzurePipelines.md and src/app/README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@mahdichtioui mahdichtioui force-pushed the dev/mach/implement-commit-validation branch from 7d8e89e to 0f198b7 Compare November 29, 2024 12:43
@mahdichtioui mahdichtioui marked this pull request as draft November 29, 2024 13:25
@jeanplevesque jeanplevesque self-requested a review November 29, 2024 13:55
Copy link
Member

@jeanplevesque jeanplevesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should have 1 commit, not 17.

build/stage-commit-validation.yaml Show resolved Hide resolved
build/config/commitlint.config.json Outdated Show resolved Hide resolved
build/azure-pipelines.yml Outdated Show resolved Hide resolved
@mahdichtioui
Copy link
Contributor Author

This PR should have 1 commit, not 17.

I have changed this PR to draft for now. I'm having a problem validating the PR commit in the pipeline. I'll clean it afterwards

@mahdichtioui mahdichtioui force-pushed the dev/mach/implement-commit-validation branch from 5bd0068 to 9b47ac1 Compare November 29, 2024 15:04
@mahdichtioui mahdichtioui marked this pull request as ready for review November 29, 2024 17:25
@mahdichtioui mahdichtioui force-pushed the dev/mach/implement-commit-validation branch from 5d1a69b to a1731e1 Compare November 29, 2024 20:23
@mahdichtioui mahdichtioui force-pushed the dev/mach/implement-commit-validation branch from a1731e1 to 0a80033 Compare December 2, 2024 14:33
@mahdichtioui mahdichtioui marked this pull request as draft December 4, 2024 09:15
@mahdichtioui mahdichtioui force-pushed the dev/mach/implement-commit-validation branch 6 times, most recently from 316e4e7 to d7c6c8c Compare December 4, 2024 12:56
@mahdichtioui mahdichtioui marked this pull request as ready for review December 4, 2024 13:45
@mahdichtioui mahdichtioui force-pushed the dev/mach/implement-commit-validation branch from d7c6c8c to 094d835 Compare December 4, 2024 16:22
@jeanplevesque jeanplevesque requested a review from a team December 4, 2024 18:19
@jeanplevesque jeanplevesque merged commit c579628 into main Dec 4, 2024
17 checks passed
@jeanplevesque jeanplevesque deleted the dev/mach/implement-commit-validation branch December 4, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants