Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Port code to dart #4

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

Lee31416
Copy link
Contributor

@Lee31416 Lee31416 commented Jun 10, 2024

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

I'm porting the review service to dart in this pr.

What is the current behavior?

N/A

What is the new behavior?

N/A

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Automated tests for the changes have been added/updated.
  • Updated CHANGELOG.md.

Other information

@Lee31416 Lee31416 self-assigned this Jun 10, 2024
@Lee31416 Lee31416 requested review from Soap-141, jeanplevesque, takla21 and Marc-Antoine-Soucy and removed request for Soap-141 June 10, 2024 21:18
README.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/review_service/memory_review_settings_source.dart Outdated Show resolved Hide resolved
lib/src/review_service/review_prompter_interface.dart Outdated Show resolved Hide resolved
lib/src/review_service/review_service.dart Show resolved Hide resolved
lib/src/review_service/review_settings.dart Outdated Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@Soap-141 Soap-141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to properly fill the PR template, you can add N/A to the current behavior or remove it.

test/src/review_service_test.dart Show resolved Hide resolved
test/src/review_service_test.mocks.dart Outdated Show resolved Hide resolved
@Lee31416 Lee31416 force-pushed the dev/topi/port-reviewservice-to-dart branch 2 times, most recently from f7327a2 to 86a0d8e Compare June 12, 2024 15:08
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Lee31416 Lee31416 force-pushed the dev/topi/port-reviewservice-to-dart branch 2 times, most recently from 830b8a0 to 44e6d08 Compare June 12, 2024 20:21
@Lee31416 Lee31416 force-pushed the dev/topi/port-reviewservice-to-dart branch from 44e6d08 to ede9651 Compare June 12, 2024 20:22
@Lee31416
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Lee31416 Lee31416 force-pushed the dev/topi/port-reviewservice-to-dart branch 6 times, most recently from be3dc91 to e155ad5 Compare June 14, 2024 15:43
@Lee31416 Lee31416 force-pushed the dev/topi/port-reviewservice-to-dart branch from e155ad5 to 6640171 Compare June 17, 2024 13:23
@Lee31416 Lee31416 requested a review from jeanplevesque June 17, 2024 13:24
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Ouillyang Ouillyang force-pushed the dev/topi/port-reviewservice-to-dart branch from 53f0c1b to 50f6832 Compare September 12, 2024 19:14
@Ouillyang Ouillyang force-pushed the dev/topi/port-reviewservice-to-dart branch from f5293e0 to 23a6484 Compare September 13, 2024 17:10
@Ouillyang Ouillyang merged commit 56647f0 into main Sep 16, 2024
3 checks passed
@Ouillyang Ouillyang deleted the dev/topi/port-reviewservice-to-dart branch September 16, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants