Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates MUI to v6 with Pigment CSS #19

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

luisdlopez
Copy link
Contributor

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

What is the current behavior?

The skeleton uses MUI v5

What is the new behavior?

The skeleton will use MUI v6 with Pigmet css.

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.

Other information

Pigment css is a zero runtine css-in-js library. Unlike emotion or styled components, the CSS is not compiled dynamically by the browser when loading components - it is fully compiled during the project's build step.

Steps to migrate from MUI 5 to 6 are documented here:

https://mui.com/material-ui/migration/migrating-to-pigment-css/

Important note: Dynamic styles (based on props, for example) no longer work. You will need to use css variables. A couple of examples (with before & after code snippets) can be found here:

https://mui.com/material-ui/migration/migrating-to-pigment-css/#migrating-dynamic-styles

frontend/vite.config.ts Outdated Show resolved Hide resolved
@luisdlopez luisdlopez marked this pull request as ready for review September 19, 2024 13:35
@luisdlopez luisdlopez merged commit 5235127 into feature/sass-modules Sep 19, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants